test(pgwire): lock binary-format round-trip for narrowed integer OIDs

Extended-query typed reads (i16/i32/i64 via tokio_postgres) against a
schemaless collection's SMALLINT/INT/BIGINT columns, asserting both the
advertised OIDs (21/23/20) and the decoded values — locking the chain
from declared width through RowDescription to the binary value encoders
that the OID fix makes reachable. Also corrects an inaccurate sentence
in the refinement fn's rustdoc (the keyword-match ordering is
consistency with the reference implementation, not load-bearing).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0193ftf9LuUWejMqe2KVWkya

Author: emanzx

nodedb/src/control/server/response_shape/schema.rs

@@ -92,10 +92,12 @@ pub fn sql_data_type_to_ddl_col_type(
 /// prefix-with-boundary logic as
 /// `pgwire::catalog::tables::collections::field_type_to_oid` (the
 /// already-correct reference implementation this mirrors): `BIGINT`/`INT8`
-/// are checked *first* so a plain `INT` prefix check can't accidentally
-/// swallow `INT8` (there is no separator between `INT` and `8` for the
-/// boundary check to reject). An unrecognized or absent `raw` leaves the
-/// base `Int8` untouched — refinement is best-effort, never a hard error.
+/// are checked *first* to mirror that reference implementation's ordering,
+/// but the order isn't load-bearing — the boundary check itself already
+/// rejects `int` as a prefix match of `int8`, since the next character
+/// (`8`) is neither `(` nor whitespace. An unrecognized or absent `raw`
+/// leaves the base `Int8` untouched — refinement is best-effort, never a
+/// hard error.
 pub fn sql_data_type_to_ddl_col_type_with_raw(
     ty: &nodedb_sql::types_expr::SqlDataType,
     raw: Option<&str>,

nodedb/tests/pgwire_extended_query_engines.rs

@@ -320,3 +320,68 @@ async fn extended_query_timeseries_null_param() {
 
     assert_eq!(rows.len(), 0, "NULL param must match 0 rows");
 }
+
+// ── Schemaless engine (binary round-trip) ────────────────────────────────────
+
+/// Binary-format round-trip for declared integer widths on a schemaless
+/// collection. tokio_postgres decodes extended-query results per the
+/// RowDescription OID, so reading each column back with a typed getter that
+/// matches the *advertised* width (`i16`/`i32`/`i64`) fails the `get` if
+/// either the OID or the binary payload width is wrong — this locks the
+/// whole chain: declared width → OID 21/23/20 → binary encoder i16/i32/i64
+/// (issue #217).
+#[tokio::test]
+async fn extended_query_schemaless_int_width_binary_roundtrip() {
+    let srv = TestServer::start().await;
+    srv.exec("CREATE COLLECTION bin_widths (id TEXT PRIMARY KEY, s SMALLINT, i INT, b BIGINT)")
+        .await
+        .expect("CREATE COLLECTION bin_widths");
+    srv.exec("INSERT INTO bin_widths (id, s, i, b) VALUES ('r1', 123, 456789, 9876543210)")
+        .await
+        .expect("INSERT bin_widths");
+
+    let stmt = srv
+        .client
+        .prepare_typed(
+            "SELECT id, s, i, b FROM bin_widths WHERE id = $1",
+            &[Type::TEXT],
+        )
+        .await
+        .expect("prepare bin_widths select");
+
+    let rows = srv
+        .client
+        .query(&stmt, &[&"r1"])
+        .await
+        .expect("execute bin_widths select");
+
+    assert_eq!(rows.len(), 1, "expected 1 row");
+
+    // Typed getters matching the advertised OIDs — a wrong OID or a
+    // wrong-width binary payload panics inside `get` before we ever reach
+    // the assertions below.
+    let s = rows[0].get::<_, i16>("s");
+    let i = rows[0].get::<_, i32>("i");
+    let b = rows[0].get::<_, i64>("b");
+    assert_eq!(s, 123);
+    assert_eq!(i, 456789);
+    assert_eq!(b, 9876543210);
+
+    // RowDescription OID check: s→INT2(21), i→INT4(23), b→INT8(20).
+    let expected: &[(&str, u32)] = &[("s", 21), ("i", 23), ("b", 20)];
+    for (col_name, expected_oid) in expected {
+        let col = rows[0]
+            .columns()
+            .iter()
+            .find(|c| c.name() == *col_name)
+            .unwrap_or_else(|| panic!("column '{col_name}' must appear in RowDescription"));
+        assert_eq!(
+            col.type_().oid(),
+            *expected_oid,
+            "bin_widths column '{}' OID must be {}, got {}",
+            col_name,
+            expected_oid,
+            col.type_().oid()
+        );
+    }
+}