refactor(types): consolidate wire format version into nodedb-types

Move WIRE_FORMAT_VERSION and MIN_WIRE_FORMAT_VERSION from the
nodedb binary crate into a new nodedb-types::wire_version module so
every crate that needs to stamp or validate the version shares a
single source of truth. nodedb::version re-exports both constants.

Tests pin the invariant that the minimum does not exceed the current
version and that zero is reserved for legacy-client handling.

Author: farhan-syah

nodedb-types/src/lib.rs

@@ -41,6 +41,7 @@ pub mod vector_ann;
 pub mod vector_distance;
 pub mod vector_index_stats;
 pub mod vector_model;
+pub mod wire_version;
 
 pub use approx::{CountMinSketch, HyperLogLog, SpaceSaving, TDigest};
 pub use array_cell::ArrayCell;

nodedb-types/src/wire_version.rs

@@ -0,0 +1,39 @@
+//! Single source of truth for the `WIRE_FORMAT_VERSION` constant
+//! shared between every crate that needs to stamp or interpret it.
+//!
+//! This is the *cluster-wide* wire format version, distinct from:
+//! - `nodedb_cluster::wire::WIRE_VERSION` (the binary frame layout
+//!   version of the `VShardEnvelope`),
+//! - the v3 RPC frame header version in
+//!   `nodedb_cluster::rpc_codec::header` (a private constant of that
+//!   module).
+//!
+//! Bump this when the SPSC bridge, WAL, or RPC payload schemas change
+//! in a way that requires a coordinated upgrade. Readers MUST reject
+//! messages stamped with a higher version than their own; readers
+//! SHOULD accept N-1 for rolling-upgrade compatibility.
+
+/// Cluster-wide wire format version. Stamped on every `NodeInfo` and
+/// returned by `nodedb::version::WIRE_FORMAT_VERSION` (a re-export).
+pub const WIRE_FORMAT_VERSION: u16 = 4;
+
+/// Minimum wire format version this build can read. Frames stamped
+/// below this are rejected.
+pub const MIN_WIRE_FORMAT_VERSION: u16 = 1;
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn min_does_not_exceed_current() {
+        assert!(MIN_WIRE_FORMAT_VERSION <= WIRE_FORMAT_VERSION);
+    }
+
+    #[test]
+    fn current_is_nonzero() {
+        // Version 0 is reserved for "unknown / legacy" handling on
+        // downstream paths and must never be the active version.
+        assert!(WIRE_FORMAT_VERSION > 0);
+    }
+}

nodedb/src/version.rs

@@ -8,14 +8,14 @@
 /// Current NodeDB version.
 pub const VERSION: &str = env!("CARGO_PKG_VERSION");
 
-/// Wire format version (incremented when SPSC bridge, WAL, or RPC formats change).
-/// Readers MUST reject messages with wire_version > their own.
-/// Readers SHOULD accept messages with wire_version == their own or one less (N-1).
-pub const WIRE_FORMAT_VERSION: u16 = 4;
-
-/// Minimum wire format version this build can read.
-/// Messages below this version are rejected.
-pub const MIN_WIRE_FORMAT_VERSION: u16 = 1;
+/// Wire format version. Re-exported from `nodedb_types::wire_version`,
+/// which is the single source of truth shared with `nodedb-cluster`
+/// and any other crate that stamps or interprets the value.
+///
+/// Readers MUST reject messages with wire_version > their own. Readers
+/// SHOULD accept messages with wire_version == their own or one less
+/// (N-1).
+pub use nodedb_types::wire_version::{MIN_WIRE_FORMAT_VERSION, WIRE_FORMAT_VERSION};
 
 /// Wire version assigned to legacy clients that send wire_version == 0.
 /// Must always equal MIN_WIRE_FORMAT_VERSION to prevent silent upgrades