feat: sandbox (#44)

* feat: sandbox

* fix: sandbox client for oauth

* chore: fix lint

* chore: fix shell, port forward

Author: BhautikChudasama

.golangci.yml

@@ -19,6 +19,33 @@ linters:
     - gosec
     - copyloopvar
     - errorlint
+  settings:
+    errcheck:
+      check-type-assertions: true
+      check-blank: true
+    govet:
+      enable-all: true
+      disable:
+        - fieldalignment
+    revive:
+      rules:
+        - name: exported
+          disabled: false
+        - name: error-return
+          disabled: false
+        - name: error-strings
+          disabled: false
+        - name: indent-error-flow
+          disabled: false
+    gosec:
+      excludes:
+        - G304
+  exclusions:
+    rules:
+      - path: _test\.go
+        linters:
+          - errcheck
+          - gocritic
 
 formatters:
   enable:
@@ -29,34 +56,7 @@ formatters:
       local-prefixes:
         - github.com/NodeOps-app/createos-cli
 
-linters-settings:
-  errcheck:
-    check-type-assertions: true
-    check-blank: true
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment
-  revive:
-    rules:
-      - name: exported
-        disabled: false
-      - name: error-return
-        disabled: false
-      - name: error-strings
-        disabled: false
-      - name: indent-error-flow
-        disabled: false
-  gosec:
-    excludes:
-      - G304
-
 issues:
-  exclude-rules:
-    - path: _test\.go
-      linters:
-        - errcheck
-        - gocritic
   max-issues-per-linter: 0
   max-same-issues: 0
 

cmd/ask/ask.go

@@ -64,10 +64,13 @@ func NewAskCommand() *cli.Command {
 				pterm.Info.Println("The 'ask' command uses OpenCode (https://opencode.ai), an open-source AI coding\nassistant, to power the CreateOS AI agent. It lets you manage your infrastructure\nusing natural language right from the terminal.")
 				fmt.Println()
 
-				install, _ := pterm.DefaultInteractiveConfirm.
+				install, err := pterm.DefaultInteractiveConfirm.
 					WithDefaultText("opencode is not installed. Install it now?").
 					WithDefaultValue(true).
 					Show()
+				if err != nil {
+					return err
+				}
 				if !install {
 					return fmt.Errorf("opencode is required for the ask command\n\n  Install it manually:\n    curl -fsSL https://opencode.ai/install | bash")
 				}
@@ -77,7 +80,7 @@ func NewAskCommand() *cli.Command {
 				installCmd.Stdin = os.Stdin
 				installCmd.Stdout = os.Stdout
 				installCmd.Stderr = os.Stderr
-				if err := installCmd.Run(); err != nil {
+				if err = installCmd.Run(); err != nil {
 					return fmt.Errorf("failed to install opencode: %w", err)
 				}
 

cmd/auth/login.go

@@ -112,7 +112,7 @@ func loginWithBrowser() error {
 	pterm.Println(pterm.Gray("  " + authURL))
 	fmt.Println()
 
-	if err := internaloauth.OpenBrowser(authURL); err != nil {
+	if err = internaloauth.OpenBrowser(authURL); err != nil {
 		pterm.Warning.Println("Could not open browser automatically. Please open the URL above.")
 	} else {
 		pterm.Info.Println("Waiting for you to complete login in your browser...")

cmd/cronjobs/activities.go

@@ -71,7 +71,7 @@ func newCronjobsActivitiesCommand() *cli.Command {
 						log,
 					})
 				}
-				_ = pterm.DefaultTable.WithHasHeader().WithData(tableData).Render()
+				_ = pterm.DefaultTable.WithHasHeader().WithData(tableData).Render() //nolint:errcheck
 				fmt.Println()
 			})
 			return nil

cmd/cronjobs/list.go

@@ -53,7 +53,7 @@ func newCronjobsListCommand() *cli.Command {
 						cj.CreatedAt.Format("2006-01-02 15:04:05"),
 					})
 				}
-				_ = pterm.DefaultTable.WithHasHeader().WithData(tableData).Render()
+				_ = pterm.DefaultTable.WithHasHeader().WithData(tableData).Render() //nolint:errcheck
 				fmt.Println()
 			})
 			return nil

cmd/cronjobs/update.go

@@ -62,7 +62,7 @@ Examples:
 			// Decode existing settings for defaults in both TTY and non-TTY.
 			var currentSettings api.HTTPCronjobSettings
 			if existing.Settings != nil {
-				if err := json.Unmarshal(*existing.Settings, &currentSettings); err != nil {
+				if err = json.Unmarshal(*existing.Settings, &currentSettings); err != nil {
 					return fmt.Errorf("could not parse existing cron job settings: %w", err)
 				}
 			}

cmd/deploy/deploy.go

@@ -147,7 +147,10 @@ func NewDeployCommand() *cli.Command {
 				}
 
 				// Try to auto-detect from git remote
-				dir, _ := os.Getwd()
+				dir, err := os.Getwd()
+				if err != nil {
+					return fmt.Errorf("couldn't determine your current directory — please try again from a valid working directory")
+				}
 				repoFullName := git.GetRemoteFullName(dir)
 				if repoFullName != "" {
 					for _, p := range activeProjects {
@@ -160,10 +163,10 @@ func NewDeployCommand() *cli.Command {
 						}
 						if src.VCSFullName == repoFullName {
 							pterm.Info.Printf("Detected project %s from git remote (%s)\n", p.DisplayName, repoFullName)
-							useDetected, _ := pterm.DefaultInteractiveConfirm.
+							confirm := pterm.DefaultInteractiveConfirm.
 								WithDefaultText(fmt.Sprintf("Deploy %s?", p.DisplayName)).
-								WithDefaultValue(true).
-								Show()
+								WithDefaultValue(true)
+							useDetected, _ := confirm.Show() //nolint:errcheck
 							if useDetected {
 								projectID = p.ID
 							}
@@ -281,23 +284,23 @@ func UploadDir(client *api.APIClient, projectID, displayName, dir string) error
 	defer os.Remove(zipFile.Name()) //nolint:errcheck
 	defer zipFile.Close()           //nolint:errcheck
 
-	spinner, _ := pterm.DefaultSpinner.Start("Packaging files...")
+	spinner, _ := pterm.DefaultSpinner.Start("Packaging files...") //nolint:errcheck
 
-	if err := createZip(zipFile, absDir); err != nil {
+	if err = createZip(zipFile, absDir); err != nil {
 		spinner.Fail("Packaging failed")
 		return err
 	}
 
-	stat, _ := zipFile.Stat()
-	if stat != nil && stat.Size() > maxZipSize {
+	stat, statErr := zipFile.Stat()
+	if statErr == nil && stat.Size() > maxZipSize {
 		spinner.Fail("Package too large")
 		return fmt.Errorf("deployment package is %d MB (max %d MB)\n\n  Tip: check that node_modules, .git, and build artifacts are excluded",
 			stat.Size()/(1024*1024), maxZipSize/(1024*1024))
 	}
 
 	spinner.UpdateText("Uploading...")
 
-	if err := zipFile.Close(); err != nil { //nolint:govet
+	if err = zipFile.Close(); err != nil {
 		return fmt.Errorf("could not flush deployment package: %w", err)
 	}
 
@@ -335,15 +338,15 @@ func deployUpload(c *cli.Context, client *api.APIClient, project *api.Project) e
 	defer os.Remove(zipFile.Name()) //nolint:errcheck
 	defer zipFile.Close()           //nolint:errcheck
 
-	spinner, _ := pterm.DefaultSpinner.Start("Packaging files...")
+	spinner, _ := pterm.DefaultSpinner.Start("Packaging files...") //nolint:errcheck
 
-	if err := createZip(zipFile, absDir); err != nil {
+	if err = createZip(zipFile, absDir); err != nil {
 		spinner.Fail("Packaging failed")
 		return err
 	}
 
-	stat, _ := zipFile.Stat()
-	if stat != nil && stat.Size() > maxZipSize {
+	stat, statErr := zipFile.Stat()
+	if statErr == nil && stat.Size() > maxZipSize {
 		spinner.Fail("Package too large")
 		return fmt.Errorf("deployment package is %d MB (max %d MB)\n\n  Tip: check that node_modules, .git, and build artifacts are excluded",
 			stat.Size()/(1024*1024), maxZipSize/(1024*1024))
@@ -352,7 +355,7 @@ func deployUpload(c *cli.Context, client *api.APIClient, project *api.Project) e
 	spinner.UpdateText("Uploading...")
 
 	// Close before uploading so the file is flushed
-	if err := zipFile.Close(); err != nil { //nolint:govet
+	if err = zipFile.Close(); err != nil {
 		return fmt.Errorf("could not flush deployment package: %w", err)
 	}
 
@@ -523,8 +526,15 @@ func createZip(w io.Writer, srcDir string) error {
 		// Check ignore patterns against basename and full relative path
 		baseName := filepath.Base(relPath)
 		for _, pattern := range ignorePatterns {
-			matchedBase, _ := filepath.Match(pattern, baseName)
-			matchedRel, _ := filepath.Match(pattern, filepath.ToSlash(relPath))
+			var matchedBase, matchedRel bool
+			matchedBase, err = filepath.Match(pattern, baseName)
+			if err != nil {
+				return fmt.Errorf("invalid ignore pattern %q: %w", pattern, err)
+			}
+			matchedRel, err = filepath.Match(pattern, filepath.ToSlash(relPath))
+			if err != nil {
+				return fmt.Errorf("invalid ignore pattern %q: %w", pattern, err)
+			}
 			if matchedBase || matchedRel {
 				if info.IsDir() {
 					return filepath.SkipDir

cmd/deployments/helpers.go

@@ -82,7 +82,9 @@ func pickDeployment(client *api.APIClient, projectID string, statusFilter []stri
 		})
 	}
 	fmt.Println()
-	_ = pterm.DefaultTable.WithHasHeader().WithData(tableData).Render()
+	if err = pterm.DefaultTable.WithHasHeader().WithData(tableData).Render(); err != nil {
+		pterm.Error.Println(err)
+	}
 	fmt.Println()
 
 	options := make([]string, len(deployments))

cmd/deployments/list.go

@@ -50,7 +50,9 @@ func newDeploymentsListCommand() *cli.Command {
 						d.CreatedAt.Format("2006-01-02 15:04:05"),
 					})
 				}
-				_ = pterm.DefaultTable.WithHasHeader().WithData(tableData).Render()
+				if err := pterm.DefaultTable.WithHasHeader().WithData(tableData).Render(); err != nil {
+					pterm.Error.Println(err)
+				}
 			})
 			return nil
 		},

cmd/domains/create.go

@@ -82,6 +82,6 @@ func printDNSRecords(d api.Domain) {
 		tableData = append(tableData, []string{"TXT", txt.Name + "." + d.Name, txt.Value})
 	}
 
-	_ = pterm.DefaultTable.WithHasHeader().WithData(tableData).Render()
+	_ = pterm.DefaultTable.WithHasHeader().WithData(tableData).Render() //nolint:errcheck
 	fmt.Println()
 }