Skip to content

chore: remove unused devDependencies after Node.js 22 upgrade#122

Merged
fraxken merged 3 commits into
NodeSecure:mainfrom
LouisAntoninLesieur:chore/remove-devdependencies
May 24, 2025
Merged

chore: remove unused devDependencies after Node.js 22 upgrade#122
fraxken merged 3 commits into
NodeSecure:mainfrom
LouisAntoninLesieur:chore/remove-devdependencies

Conversation

@LouisAntoninLesieur

@LouisAntoninLesieur LouisAntoninLesieur commented May 24, 2025

Copy link
Copy Markdown
Contributor

Closes #121

This PR removes unnecessary dev dependencies that became obsolete with the upgrade to Node.js v22:

  • Removed:
    • @matteo.collina/tspl
    • glob
    • c8, eslint
    • @nodesecure/eslint-config
    • registry-url
  • Updated engines.node to >=22

  • Removed Node.js 20.x from CI (after feedback)

@fraxken

fraxken commented May 24, 2025

Copy link
Copy Markdown
Member

@LouisAntoninLesieur

LouisAntoninLesieur commented May 24, 2025

Copy link
Copy Markdown
Contributor Author

You need to remove Node.js 20.x from CI: https://github.com/NodeSecure/ossf-scorecard-sdk/blob/main/.github/workflows/main.yml#L17

Thanks for the feedback! It’s my first PR here, I appreciate the guidance. I’ve updated the file to remove Node.js 20.x as requested.

@fraxken fraxken merged commit 92d650a into NodeSecure:main May 24, 2025
@fraxken

fraxken commented May 24, 2025

Copy link
Copy Markdown
Member

It's perfect, thanks you!

@allcontributors please add @LouisAntoninLesieur for code

@allcontributors

Copy link
Copy Markdown
Contributor

@fraxken

I've put up a pull request to add @LouisAntoninLesieur! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup dev depencencies

2 participants