Clean up language specifc settings

Author: NonlinearFruit

nvim/lua/plugins/bash.lua

@@ -6,7 +6,9 @@ end
 
 local function configure()
   install_lsp_and_dap_if_needed()
-  vim.bo.filetype = "sh"
+  vim.filetype.add({
+    pattern = { ["/tmp/bash%-fc.*"] = "sh" },
+  })
   vim.lsp.enable("bashls")
 end
 

nvim/lua/plugins/crontab.lua

@@ -1,5 +1,7 @@
 local function configure()
-  vim.bo.filetype = "crontab"
+  vim.filetype.add({
+    extension = { crontab = "crontab" },
+  })
 end
 
 return {

nvim/lua/plugins/csharp.lua

@@ -1,7 +1,7 @@
 local function non_standard_options()
-  vim.opt.tabstop = 4
-  vim.opt.softtabstop = 4
-  vim.opt.shiftwidth = 4
+  vim.opt_local.tabstop = 4
+  vim.opt_local.softtabstop = 4
+  vim.opt_local.shiftwidth = 4
 end
 
 local function go_to_test_file_key_mapping()

nvim/lua/plugins/d2.lua

@@ -1,6 +1,8 @@
 local function configure()
   vim.cmd("TSInstall d2")
-  vim.bo.filetype = "d2"
+  vim.filetype.add({
+    extension = { d2 = "d2" },
+  })
 end
 
 return {

nvim/lua/plugins/markdown.lua

@@ -1,17 +1,23 @@
+local function set_options()
+  vim.opt_local.spell = true
+  vim.opt_local.textwidth = 80
+end
+
 local function configure()
   require("installer").install_if_missing({
     "marksman", -- LSP requires `sudo dnf install libicu` or `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1`
   })
-  vim.opt_local.filetype = "markdown"
-  vim.opt_local.spell = true
-  vim.opt_local.textwidth = 80
+  vim.api.nvim_create_autocmd("FileType", {
+    pattern = "markdown",
+    callback = set_options,
+  })
+  set_options()
   vim.lsp.enable("marksman")
 end
 
 return {
   "local/markdown",
   config = configure,
   ft = "markdown",
-  event = "BufEnter *.page",
   virtual = true,
 }

nvim/lua/plugins/nushell.lua

@@ -1,7 +1,6 @@
 local function configure()
   -- lsp comes with nushell out-of-the-box
   vim.lsp.enable("nushell")
-  vim.bo.commentstring = "# %s"
 end
 
 return {

nvim/lua/plugins/python.lua

@@ -12,6 +12,6 @@ end
 return {
   "local/python",
   config = configure,
-  ft = "py",
+  ft = "python",
   virtual = true,
 }

nvim/lua/plugins/xml.lua

@@ -1,5 +1,7 @@
 local function configure()
-  vim.bo.filetype = "xml"
+  vim.filetype.add({
+    extension = { xaml = "xml", props = "xml", csproj = "xml" },
+  })
 end
 
 return {