Skip to content

update source_cism to cism_main_2.01.017_noresm_v9#30

Merged
TomasTorsvik merged 1 commit into
noresmfrom
feature/update_source_cism
Jun 29, 2026
Merged

update source_cism to cism_main_2.01.017_noresm_v9#30
TomasTorsvik merged 1 commit into
noresmfrom
feature/update_source_cism

Conversation

@mvertens

Copy link
Copy Markdown

No description provided.

@mvertens mvertens requested a review from hgoelzer June 26, 2026 14:09
@mvertens mvertens changed the title updated source_cism to cism_main_2.01.017_noresm_v9 update source_cism to cism_main_2.01.017_noresm_v9 Jun 26, 2026

@hgoelzer hgoelzer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@TomasTorsvik TomasTorsvik self-assigned this Jun 29, 2026
@TomasTorsvik

Copy link
Copy Markdown

I would like to update the pr-noresm3_0_bet21 branch, so I merge this now.

@TomasTorsvik TomasTorsvik added this to the NorESM3.0 milestone Jun 29, 2026
@TomasTorsvik TomasTorsvik merged commit d89e2ed into noresm Jun 29, 2026
@TomasTorsvik TomasTorsvik deleted the feature/update_source_cism branch June 29, 2026 12:43
@mvertens

Copy link
Copy Markdown
Author

@TomasTorsvik - I am really confused. I already did these merges - can we please chat?

@mvertens

Copy link
Copy Markdown
Author

@TomasTorsvik - I tagged cismwrap_2_2_007_noresm_v10 last week - this is what is needed for noresm3_0_beta21. Sorry for not updating the plans page. Are you not seeing this tag?

@TomasTorsvik

Copy link
Copy Markdown

@mvertens - sorry if I messed up here, I thought this was just a simple update to the latest CISM tag.

This is what I see on NorESMhub/CISM:

I think there is a mis-match with the tag name. You made

After that I made
cismwrap_2_2_007_noresm_v10 - which restored the deleted namelist_definition_cism.xml file. I think at the time, that you had updated with this fix in your own repository, but it was not propagated NorESMhub/CISM-wrapper. Hence, as I was not able to get your tag and I needed the update for noresm3_0_beta20 I made the v10 tag, as not to get further confused with changes in the v9 tag.

So for the NorESMhub/CISM-wrapper, I think it is correct that the latest tag should be cismwrap_2_2_007_noresm_v11.

@mvertens

Copy link
Copy Markdown
Author

@TomasTorsvik - you are right. This looks fine. Sorry for the confusion.

@TomasTorsvik

Copy link
Copy Markdown

@TomasTorsvik - you are right. This looks fine. Sorry for the confusion.

@mvertens - no worries! Good that this got cleared up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants