Skip to content

Commit 76886f9

Browse files
A few more warning fixes
1 parent bc309ab commit 76886f9

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

general/src/lan8670.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,12 +245,14 @@ static int mmd_read_register(lan8670_t *lan, uint16_t mmd_addr, uint16_t registe
245245
}
246246

247247
/* Read data from MMDAD */
248-
status = lan->IO.ReadReg(lan->DevAddr, REG_MMDAD, value);
248+
uint32_t read = 0;
249+
int status = lan->IO.ReadReg(lan->DevAddr, REG_MMDAD, &read);
249250
if (status != 0) {
250251
debug(lan, "ERROR 4003: mmd_read_register() failed when reading REG_MMDAD (Status: %d)\n", status);
251252
return LAN8670_STATUS_READ_ERROR;
252253
}
253254

255+
*value = (uint16_t)(read & 0xFFFF); // Truncate to 16 bits
254256
return LAN8670_STATUS_OK;
255257
}
256258
// EXAMPLE USAGE:
@@ -315,8 +317,10 @@ static int mmd_write_register(lan8670_t *lan, uint16_t mmd_addr, uint16_t regist
315317
* @param value Pointer to store the read value.
316318
* @return Status.
317319
*/
318-
static int mmd_read_register_field(lan8670_t *lan, uint16_t mmd_addr, uint16_t register_offset, int start, int end, uint16_t *value)
320+
static int __attribute__((unused)) mmd_read_register_field(lan8670_t *lan, uint16_t mmd_addr, uint16_t register_offset, int start, int end, uint16_t *value)
319321
{
322+
// NOTE: Remove the __attribute__((unused)) if this function gets used.
323+
320324
/* Validate bit range */
321325
if (start > end) {
322326
debug(lan, "ERROR 6000: mmd_read_register_field() invalid bit range: start (%d) > end (%d)\n", start, end);

0 commit comments

Comments
 (0)