Made it so DevAddr gets hardcoded in LAN8670_Init()

Author: bjackson312006

general/include/lan8670.h

@@ -47,12 +47,10 @@ typedef struct {
 /**
  * @brief Initializes a LAN8670 instance.
  * @param lan Pointer to the lan8670_t instance.
- * @param device_address The address of the LAN8670.
- * @param read Function pointer for reading data from the LAN8670.
- * @param write Function pointer for writing data to the LAN8670.
+ * @param DevAddr The device address of the LAN8670. This is a 5-bit value indicated by the PHYAD0-PHYAD4 pins and their pull-up/pull-down configuration.
  * @return Status.
  */
-int32_t LAN8670_Init(lan8670_t *lan); // Initializes a LAN8670 instance.
+int32_t LAN8670_Init(lan8670_t *lan, uint32_t DevAddr); // Initializes a LAN8670 instance.
 
 /**
  * @brief Performs a software reset of the LAN8670 Ethernet PHY.

general/src/lan8670.c

@@ -411,16 +411,21 @@ static int mmd_write_register_field(lan8670_t *lan, uint16_t mmd_addr, uint16_t
 
 /**** API FUNCTIONS ****/
 
-int32_t LAN8670_Init(lan8670_t *lan)
+int32_t LAN8670_Init(lan8670_t *lan, uint32_t DevAddr)
 {
-    // Set the device address to the SMIADR[4:0] field of the Strap Control 0 Register.
+    // Store the DevAddr
+    lan->DevAddr = DevAddr;
+    
+    // Double-check that DevAddr is the same as what's stored in the SMIADR[4:0] field of the Strap Control 0 Register.
     uint32_t buffer = 0;
 	int32_t status = read_register_field(lan, REG_STRAP_CTRL0, 0, 4, &buffer);
     if(status != 0) {
         debug(lan, "ERROR 0000: LAN8670_Init() failed to read Strap Control Register 0 (Status: %d)\n", status);
         return LAN8670_STATUS_READ_ERROR;
     }
-    lan->DevAddr = buffer;
+    if(lan->DevAddr != buffer) {
+        PRINTLN_WARNING("The hardcoded DevAddr value isn't the same as what's stored in SMIADR[4:0]. Something weird is probably going on (how did it even read the register in the first place)? (DevAddr=%d, SMIADR[4:0]=%d).", lan->DevAddr, buffer);
+    }
 
 	lan->debug = false; // Default to no debugging.