linting and tests

Author: chpy04

src/backend/src/services/organizations.services.ts

@@ -1,5 +1,5 @@
 import { Organization, User } from '@prisma/client';
-import { LinkCreateArgs, ProjectPreview, isAdmin, isMember } from 'shared';
+import { LinkCreateArgs, ProjectPreview, RoleEnum, isAdmin, isAtLeastRank } from 'shared';
 import prisma from '../prisma/prisma';
 import {
   AccessDeniedAdminOnlyException,
@@ -424,7 +424,7 @@ export default class OrganizationsService {
     if (organization.dateDeleted) {
       throw new DeletedException('Organization', organizationId);
     }
-    if (!(await userHasPermission(submitter.userId, organization.organizationId, isMember))) {
+    if (!(await userHasPermission(submitter.userId, organizationId, (role) => isAtLeastRank(RoleEnum.MEMBER, role)))) {
       throw new AccessDeniedException("Only members of an organization can retrieve it's guide link");
     }
     return organization.partReviewGuideLink;

src/backend/src/services/part-review.services.ts

@@ -1,5 +1,5 @@
 import { Organization, User } from '@prisma/client';
-import { userHasPermission, getUserRole } from '../utils/users.utils';
+import { userHasPermission } from '../utils/users.utils';
 import {
   FrequentlyAskedQuestion,
   isAdmin,
@@ -857,7 +857,7 @@ export default class PartReviewService {
    * @returns the created and transformed PartReviewRequest
    */
   static async createPartReviewRequest(partId: string, requester: User, reviewerId: string, organizationId: string) {
-    const part = await PartReviewService.getPartWithQueryArgs(partId, requester.userId, organizationId);
+    await PartReviewService.getPartWithQueryArgs(partId, requester.userId, organizationId);
 
     if (!userHasPermission(requester.userId, organizationId, (role) => isAtLeastRank(RoleEnum.MEMBER, role))) {
       throw new AccessDeniedGuestException('Guests must be at least members to access this part.');