Skip to content

Commit 4378e5c

Browse files
authored
Merge pull request #4277 from Northeastern-Electric-Racing/#4269-Event-Updating-Slack-Message
#4269 event updating slack message
2 parents 69a3cee + 97fd84c commit 4378e5c

3 files changed

Lines changed: 24 additions & 8 deletions

File tree

src/backend/src/controllers/calendar.controllers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ export default class CalendarController {
283283
mention
284284
} = req.body;
285285

286-
const parsedScheduleSlots = scheduleSlots.map((slot: any) => ({
286+
const parsedScheduleSlots = scheduleSlots.map((slot: { allDay: boolean; startTime?: string; endTime?: string }) => ({
287287
startTime: slot.startTime ? new Date(slot.startTime) : undefined,
288288
endTime: slot.endTime ? new Date(slot.endTime) : undefined,
289289
allDay: slot.allDay

src/backend/src/services/calendar.services.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,20 +1527,20 @@ export default class CalendarService {
15271527
data: { availability: updatedAvailability }
15281528
});
15291529
}
1530-
15311530
const { eventTypeId } = updatedEvent;
15321531
const foundEventType = await prisma.event_Type.findUnique({
15331532
where: { eventTypeId }
15341533
});
1535-
1534+
const edittedEvent = eventTransformer(updatedEvent);
15361535
if (foundEventType?.sendSlackNotifications) {
15371536
await sendEventScheduledSlackNotif(
15381537
updatedEvent.notificationSlackThreads,
15391538
eventTransformer(updatedEvent),
15401539
event.status === Event_Status.SCHEDULED
15411540
);
15421541
}
1543-
return eventTransformer(updatedEvent);
1542+
1543+
return edittedEvent;
15441544
}
15451545

15461546
/**

src/frontend/src/pages/CalendarPage/Components/EditEventModal.tsx

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import type { EventInstance, EventType, EventDocumentUploadArgs } from 'shared';
44
import { convertEventToFormValues } from '../../../utils/calendar.utils';
55
import { useEditEvent, useEditScheduleSlot, useUploadManyDocuments } from '../../../hooks/calendar.hooks';
66
import { useToast } from '../../../hooks/toasts.hooks';
7+
import ErrorPage from '../../ErrorPage';
8+
import LoadingIndicator from '../../../components/LoadingIndicator';
79

810
export interface EditEventModalProps {
911
open: boolean;
@@ -14,9 +16,23 @@ export interface EditEventModalProps {
1416

1517
const EditEventModal: React.FC<EditEventModalProps> = ({ open, onClose, event, eventTypes }) => {
1618
const toast = useToast();
17-
const { mutateAsync: editEvent } = useEditEvent(event.eventId);
18-
const { mutateAsync: editScheduleSlot } = useEditScheduleSlot(event.eventId, event.scheduleSlotId);
19+
const {
20+
isLoading: editEventIsLoading,
21+
isError: editEventIsError,
22+
error: editEventError,
23+
mutateAsync: editEvent
24+
} = useEditEvent(event.eventId);
1925
const { mutateAsync: uploadDocuments } = useUploadManyDocuments();
26+
const {
27+
isLoading: editScheduleSlotIsLoading,
28+
isError: editScheduleSlotIsError,
29+
error: editScheduleSlotError,
30+
mutateAsync: editScheduleSlot
31+
} = useEditScheduleSlot(event.eventId, event.scheduleSlotId);
32+
33+
if (editEventIsError) return <ErrorPage message={editEventError?.message} />;
34+
if (editScheduleSlotIsError) return <ErrorPage message={editScheduleSlotError?.message} />;
35+
if (editEventIsLoading || editScheduleSlotIsLoading) return <LoadingIndicator />;
2036

2137
const initialValues = convertEventToFormValues(event);
2238

@@ -34,8 +50,6 @@ const EditEventModal: React.FC<EditEventModalProps> = ({ open, onClose, event, e
3450
}))
3551
};
3652

37-
const editedEvent = await editEvent(editArgs);
38-
3953
// If there are schedule slot changes, update the schedule slot separately
4054
if (editScheduleSlotArgs) {
4155
await editScheduleSlot({
@@ -46,6 +60,8 @@ const EditEventModal: React.FC<EditEventModalProps> = ({ open, onClose, event, e
4660
});
4761
}
4862

63+
const editedEvent = await editEvent(editArgs);
64+
4965
// Handle document uploads
5066
const filesToUpload = documentFiles
5167
.map((doc: EventDocumentUploadArgs) => doc.file)

0 commit comments

Comments
 (0)