Merge pull request #3476 from Northeastern-Electric-Racing/#3435-implement-action-button

#3435 implemented part page actions button

Author: Zwendle

src/backend/src/controllers/part-review.controllers.ts

@@ -83,7 +83,7 @@ export default class PartReviewController {
 
   static async updatePart(req: Request, res: Response, next: NextFunction) {
     try {
-      const { index, commonName, description, reviewStatus, tagIds, assigneeIds } = req.body;
+      const { index, commonName, description, reviewStatus, tagIds, assigneeIds, reviewerIds } = req.body;
       const { partId } = req.params;
       const part = await PartReviewService.updatePart(
         req.organization.organizationId,
@@ -94,7 +94,8 @@ export default class PartReviewController {
         description,
         reviewStatus,
         tagIds,
-        assigneeIds
+        assigneeIds,
+        reviewerIds
       );
       res.status(200).json(part);
     } catch (error: unknown) {

src/backend/src/routes/parts.routes.ts

@@ -61,6 +61,14 @@ partsRouter.post(
   PartReviewController.createSubmission
 );
 
+partsRouter.post(
+  '/submission/:submissionId/update',
+  nonEmptyString(body('name')),
+  body('notes').optional().isString(),
+  validateInputs,
+  PartReviewController.updateSubmission
+);
+
 partsRouter.get('/tags', PartReviewController.getAllPartTags);
 partsRouter.get('/faqs', PartReviewController.getAllPartReviewFAQS);
 
@@ -173,6 +181,7 @@ partsRouter.post(
   body('reviewStatus').custom((value) => Object.values(Review_Status).includes(value)),
   body('tagIds').isArray(),
   body('assigneeIds').isArray(),
+  body('reviewerIds').isArray(),
   validateInputs,
   PartReviewController.updatePart
 );

src/backend/src/services/part-review.services.ts

@@ -213,6 +213,7 @@ export default class PartReviewService {
   }
 
   static async uploadFile(file: Express.Multer.File) {
+    console.log('Service Function file', file);
     const data = await uploadFile(file);
 
     if (!data?.id) {
@@ -231,7 +232,8 @@ export default class PartReviewService {
     description: string,
     reviewStatus: Review_Status,
     tagIds: string[],
-    assigneeIds: string[]
+    assigneeIds: string[],
+    reviewerIds: string[]
   ) {
     const part = await prisma.part.findUnique({
       where: { partId },
@@ -247,24 +249,63 @@ export default class PartReviewService {
 
     if (!hasPermission) throw new AccessDeniedException('Only leadership and the part creator can update part data');
 
-    const updatedPart = await prisma.part.update({
-      where: { partId },
-      data: {
-        index,
-        commonName,
-        description,
-        status: reviewStatus,
-        tags: {
-          set: tagIds.map((partTagId) => ({ partTagId }))
+    const editedPart = await prisma.$transaction(async (tx) => {
+      const editedPart = await tx.part.update({
+        where: { partId },
+        data: {
+          index,
+          commonName,
+          description,
+          status: reviewStatus,
+          tags: {
+            set: tagIds.map((partTagId) => ({ partTagId }))
+          },
+          assignees: {
+            set: assigneeIds.map((userId) => ({ userId }))
+          }
         },
-        assignees: {
-          set: assigneeIds.map((userId) => ({ userId }))
-        }
-      },
-      ...getPartQueryArgs(organizationId)
+        ...getPartQueryArgs(organizationId)
+      });
+
+      const reviewersToAdd = reviewerIds.filter(
+        (id) => !editedPart.reviewRequests.some((reviewReq) => reviewReq.reviewerRequested.userId === id)
+      );
+
+      await Promise.all(
+        reviewersToAdd.map(async (id) => {
+          return tx.partReviewRequest.create({
+            data: {
+              part: {
+                connect: {
+                  partId: editedPart.partId
+                }
+              },
+              requester: { connect: { userId: updater.userId } },
+              reviewerRequested: { connect: { userId: id } }
+            }
+          });
+        })
+      );
+
+      const reviewRequestsToRemove = editedPart.reviewRequests.filter(
+        (reviewReq) => !reviewerIds.includes(reviewReq.reviewerRequested.userId)
+      );
+
+      await Promise.all(
+        reviewRequestsToRemove.map(async (reviewReq) => {
+          return tx.partReviewRequest.update({
+            where: { partReviewRequestId: reviewReq.partReviewRequestId },
+            data: {
+              dateDeleted: new Date()
+            }
+          });
+        })
+      );
+
+      return editedPart;
     });
 
-    return partTransformer(updatedPart);
+    return partTransformer(editedPart);
   }
 
   static async deletePart(partId: string, deleter: User, organizationId: string) {

src/backend/tests/unit/part-review.test.ts

@@ -215,7 +215,8 @@ describe('part review tests', () => {
       'new description',
       Review_Status.IN_REVIEW,
       [tag2.partTagId],
-      [superman.userId, nonAdmin.userId]
+      [superman.userId, nonAdmin.userId],
+      [batman.userId]
     );
 
     expect(updatedPart.commonName).toBe('part2');
@@ -250,7 +251,8 @@ describe('part review tests', () => {
           'new description',
           Review_Status.IN_REVIEW,
           [tag2.partTagId],
-          [superman.userId, nonAdmin.userId]
+          [superman.userId, nonAdmin.userId],
+          [batman.userId]
         )
     ).rejects.toThrow(new DeletedException('Part', part.partId));
   });
@@ -307,7 +309,8 @@ describe('part review tests', () => {
           'new description',
           Review_Status.IN_REVIEW,
           [],
-          [superman.userId, nonAdmin.userId]
+          [superman.userId, nonAdmin.userId],
+          [batman.userId]
         )
     ).rejects.toThrow(new AccessDeniedException('Only leadership and the part creator can update part data'));
   });

src/frontend/src/hooks/part-review.hooks.ts

@@ -190,7 +190,7 @@ export const useUploadPreviewImage = (partId: string) => {
  */
 export const useDeletePart = (partId: string) => {
   const queryClient = useQueryClient();
-  return useMutation<{ message: string }, Error, any>(
+  return useMutation<{ message: string }, Error, void>(
     ['parts', 'delete'],
     async () => {
       const { data } = await deletePart(partId);

src/frontend/src/pages/PartPage/PartPage.tsx

@@ -14,6 +14,7 @@ import PartSubmissionDetails from './PartPageComponents/PartSubmissionDetails';
 import PartOverview from './PartPageComponents/PartOverview';
 import PartHistoryView from './PartPageComponents/PartHistoryView';
 import ReviewSidebar from './PartPageComponents/ReviewPage';
+import PartActionsMenu from './PartPageComponents/PartActionsMenu';
 
 const PartPage: React.FC = () => {
   interface ParamTypes {
@@ -186,6 +187,14 @@ const PartPage: React.FC = () => {
         { name: `${wbsPipe(project.wbsNum)} - ${project.name}`, route: `${routes.PROJECTS}/${wbsNum}` },
         { name: 'Files', route: `${routes.PROJECTS}/${wbsNum}/parts-review` }
       ]}
+      headerRight={
+        <PartActionsMenu
+          part={partWithAllReviews}
+          submissionIndex={subIndex}
+          reviewIndex={reviewIndex}
+          wbsNum={validateWBS(wbsNum)}
+        />
+      }
     >
       <Breadcrumbs sx={{ mb: 2 }}></Breadcrumbs>
       <Grid container px={2} gap={5}>