Skip to content

Commit 5855c8a

Browse files
committed
test fix
1 parent 1ec3cbc commit 5855c8a

1 file changed

Lines changed: 12 additions & 23 deletions

File tree

src/frontend/src/tests/utils/part.utils.test.ts

Lines changed: 12 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -152,40 +152,29 @@ describe('Part Submission History', () => {
152152
it('User requested single review', () => {
153153
expect(completePartHistory(part1)[2]).toBe('[01/03/24] - Chris Pyle requested a review from Griffin Cooper.');
154154
});
155-
it('Reviewer began reviewing submission', () => {
156-
expect(completePartHistory(part1)[3]).toBe('[01/04/24] - Griffin Cooper began reviewing Submission #1.');
157-
});
158-
it('Reviewer finished reviewing submission', () => {
159-
expect(completePartHistory(part1)[4]).toBe(
155+
it('Reviewer reviewed submission (same day as created so only 1 note)', () => {
156+
expect(completePartHistory(part1)[3]).toBe(
160157
'[01/05/24] - Griffin Cooper reviewed Submission #1 (in Submission #1 Review).'
161158
);
162159
});
163160
it('User uploaded second submission w/o part name', () => {
164-
expect(completePartHistory(part1)[5]).toBe('[01/06/24] - Chris Pyle uploaded Submission #2.');
161+
expect(completePartHistory(part1)[4]).toBe('[01/06/24] - Chris Pyle uploaded Submission #2.');
165162
});
166163
it('User requested review from two people combined', () => {
167-
expect(completePartHistory(part1)[6]).toBe(
164+
expect(completePartHistory(part1)[5]).toBe(
168165
'[01/07/24] - Chris Pyle re-requested a review from Griffin Cooper and requested a review from Zachary Wen.'
169166
);
170167
});
171-
it('Reviewer began reviewing Submission #2', () => {
172-
expect(completePartHistory(part1)[7]).toBe('[01/08/24] - Zachary Wen began reviewing Submission #2.');
173-
});
174-
it('Reviewer finished reviewing Submission #2', () => {
175-
expect(completePartHistory(part1)[8]).toBe('[01/09/24] - Zachary Wen reviewed Submission #2 (in Submission #2 Review).');
168+
it('User reviewed second submission', () => {
169+
expect(completePartHistory(part1)[6]).toBe('[01/09/24] - Zachary Wen reviewed Submission #2 (in Submission #2 Review).');
176170
});
177-
it('Submission 3', () => {
178-
expect(completePartHistory(part1)[9]).toBe('[01/10/24] - Chris Pyle uploaded Submission #3.');
171+
it('User uploaded third submission', () => {
172+
expect(completePartHistory(part1)[7]).toBe('[01/10/24] - Chris Pyle uploaded Submission #3.');
179173
});
180-
it('Re-Request Review', () => {
181-
expect(completePartHistory(part1)[10]).toBe('[01/11/24] - Chris Pyle re-requested a review from Zachary Wen.');
174+
it('User re requests review', () => {
175+
expect(completePartHistory(part1)[8]).toBe('[01/11/24] - Chris Pyle re-requested a review from Zachary Wen.');
182176
});
183-
it('Began Reviewing', () => {
184-
expect(completePartHistory(part1)[11]).toBe('[01/12/24] - Zachary Wen began reviewing Submission #3.');
185-
});
186-
it('Last Review', () => {
187-
expect(completePartHistory(part1)[12]).toBe(
188-
'[01/13/24] - Zachary Wen reviewed Submission #3 (in Submission #3 Review).'
189-
);
177+
it('User approves part (last review and part status is approved)', () => {
178+
expect(completePartHistory(part1)[9]).toBe('[01/13/24] - Zachary Wen approved Submission #3.');
190179
});
191180
});

0 commit comments

Comments
 (0)