Skip to content

Commit 61ac3dc

Browse files
committed
requested changes
1 parent 3e71971 commit 61ac3dc

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/backend/src/routes/tasks.routes.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ tasksRouter.post(
4949
intMinZero(body('wbsNum.carNumber')),
5050
intMinZero(body('wbsNum.projectNumber')),
5151
intMinZero(body('wbsNum.workPackageNumber')),
52+
validateInputs,
5253
TasksController.editTask
5354
);
5455

src/frontend/src/pages/GanttPage/ProjectGanttChart/AddGanttTaskModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ const AddGanttTaskModal: React.FC<AddGanttTaskModalProps> = ({ showModal, handle
6464
}
6565
});
6666

67-
if (!users || usersIsLoading) return <LoadingIndicator />;
6867
if (usersIsError) return <ErrorPage message={usersError?.message} />;
68+
if (!users || usersIsLoading) return <LoadingIndicator />;
6969

7070
const options: { label: string; id: string }[] = users.map(taskUserToAutocompleteOption);
7171
const wpOptions: { label: string; wbsNum: WbsNumber }[] = workPackages.map((wp) => ({

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/TaskList/v2/TaskListContent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ export const TaskListContent = ({ wbsNum }: TaskListContentProps) => {
3636
setColumnHeights((prev) => ({ ...prev, [status]: height }));
3737
}, []);
3838

39-
if (isLoading || !tasksByStatus) return <LoadingIndicator />;
4039
if (isError) return <ErrorPage message={error?.message} />;
40+
if (isLoading || !tasksByStatus) return <LoadingIndicator />;
4141

4242
const onDeleteTask = (taskId: string) => {
4343
setTasksByStatus((prev) => {

0 commit comments

Comments
 (0)