Merge pull request #4224 from Northeastern-Electric-Racing/4218-uploads-not-displaying-on-parts-review-page

4218-uploads-not-displaying-on-parts-review-page clear stale files state when part form modals close

Author: wavehassman

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/PartReview/PartReviewComponents/PartFormModels/ReviewFormModal.tsx

@@ -23,8 +23,15 @@ const ReviewFormModal = ({ open, handleClose, defaultValues, onSubmit, partsInPr
   const toast = useToast();
   const [files, setFiles] = useState<File[]>([]);
   const [uploading, setUploading] = useState(false);
+  const [selectedPartIndex, setSelectedPartIndex] = useState<number>();
   const { mutateAsync: uploadFile } = useUploadFile();
 
+  const handleCloseAndReset = () => {
+    setFiles([]);
+    setSelectedPartIndex(undefined);
+    handleClose();
+  };
+
   const schema = yup.object().shape({
     submissionId: yup.string().required(),
     notes: yup.string().optional(),
@@ -55,8 +62,6 @@ const ReviewFormModal = ({ open, handleClose, defaultValues, onSubmit, partsInPr
     name: 'fileIds'
   });
 
-  const [selectedPartIndex, setSelectedPartIndex] = useState<number>();
-
   const onFormSubmit = async (data: { submissionId: string; status: Review_Status; notes?: string; fileIds: string[] }) => {
     try {
       handleClose();
@@ -88,7 +93,7 @@ const ReviewFormModal = ({ open, handleClose, defaultValues, onSubmit, partsInPr
   return (
     <NERFormModal
       open={open}
-      onHide={handleClose}
+      onHide={handleCloseAndReset}
       title={!!defaultValues ? 'Edit Review' : 'New Review'}
       reset={() => reset()}
       handleUseFormSubmit={handleSubmit}

src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/PartReview/PartReviewComponents/PartFormModels/SubmissionFormModal.tsx

@@ -39,6 +39,11 @@ const SubmissionFormModal = ({
   const [uploading, setUploading] = useState(false);
   const { mutateAsync: uploadFile } = useUploadFile();
 
+  const handleCloseAndReset = () => {
+    setFiles([]);
+    handleClose();
+  };
+
   const schema = yup.object().shape({
     partId: yup.string().required(),
     name: yup.string().required(),
@@ -102,7 +107,7 @@ const SubmissionFormModal = ({
   return (
     <NERFormModal
       open={open}
-      onHide={handleClose}
+      onHide={handleCloseAndReset}
       title={!!defaultValues ? 'Edit Submission Details' : 'New Submission'}
       reset={() => reset()}
       handleUseFormSubmit={handleSubmit}