Merge pull request #3480 from Northeastern-Electric-Racing/final-misc-changes

Final misc changes

Author: walker-sean

src/backend/src/controllers/part-review.controllers.ts

@@ -9,7 +9,7 @@ export default class PartReviewController {
       const { wbsNum, indexNum } = req.params;
 
       const wbsNumber: WbsNumber = validateWBS(wbsNum);
-      const part = await PartReviewService.getPart(req.organization, wbsNumber, indexNum);
+      const part = await PartReviewService.getPart(req.organization, req.currentUser, wbsNumber, indexNum);
       res.status(200).json(part);
     } catch (error: unknown) {
       next(error);
@@ -148,6 +148,16 @@ export default class PartReviewController {
     }
   }
 
+  static async deleteReview(req: Request, res: Response, next: NextFunction) {
+    try {
+      const { reviewId } = req.params;
+      await PartReviewService.deleteReview(reviewId, req.currentUser, req.organization.organizationId);
+      res.status(200).json({ message: 'Successfully deleted review' });
+    } catch (error: unknown) {
+      next(error);
+    }
+  }
+
   static async createSubmission(req: Request, res: Response, next: NextFunction) {
     try {
       const { partId, name, fileIds, notes } = req.body;
@@ -362,6 +372,26 @@ export default class PartReviewController {
     }
   }
 
+  static async notifyReviewer(req: Request, res: Response, next: NextFunction) {
+    try {
+      const { reviewerId, partId } = req.body;
+      await PartReviewService.notifyReviewer(reviewerId, partId, req.organization.organizationId);
+      res.status(200).json({ message: 'Successfully notified reviewer' });
+    } catch (error) {
+      next(error);
+    }
+  }
+
+  static async notifyAssignee(req: Request, res: Response, next: NextFunction) {
+    try {
+      const { assigneeId, partId } = req.body;
+      await PartReviewService.notifyAssignee(assigneeId, partId, req.organization.organizationId);
+      res.status(200).json({ message: 'Successfully notified assignee' });
+    } catch (error) {
+      next(error);
+    }
+  }
+
   static async createPartReviewPopup(req: Request, res: Response, next: NextFunction) {
     try {
       const user = req.currentUser;

src/backend/src/prisma/seed-data/parts.seed.ts

@@ -11,7 +11,6 @@ const basicPart = (projectId: string, userCreatedId: string, assigneeIds: string
       index: 1,
       commonName: 'Basic Part',
       description: 'Basic part with all fields populated',
-      previewImageId: 'https://NER.com/basicpart.jpg',
       status: 'IN_PROGRESS',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -32,7 +31,6 @@ const partWithoutDescription = (projectId: string, userCreatedId: string, assign
     data: {
       index: 2,
       commonName: 'Part without description',
-      previewImageId: 'https://NER.com/partwithoutdes.jpg',
       status: 'IN_PROGRESS',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -74,7 +72,6 @@ const partWithEmptyHistory = (projectId: string, userCreatedId: string, assignee
       index: 4,
       commonName: 'Part with empty history',
       description: 'Basic part but with empty history',
-      previewImageId: 'https://NER.com/partemptyhistory.jpg',
       status: 'IN_PROGRESS',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -95,7 +92,6 @@ const partWithLongName = (projectId: string, userCreatedId: string, assigneeIds:
       index: 5,
       commonName: 'ThisPartHasANameThatIsWayTooLongAndMightCauseProblemsWithVisibilityOnTheWebsiteMaybeIDK',
       description: 'part with super long name',
-      previewImageId: 'https://NER.com/partwithlongname.jpg',
       status: 'IN_PROGRESS',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -116,7 +112,6 @@ const partIndexNegative = (projectId: string, userCreatedId: string, assigneeIds
       index: -1,
       commonName: 'Part with negative index',
       description: 'This parts index is negative',
-      previewImageId: 'https://NER.com/negativeindexpart.jpg',
       status: 'IN_PROGRESS',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -137,7 +132,6 @@ const partIndexZero = (projectId: string, userCreatedId: string, assigneeIds: st
       index: 0,
       commonName: 'Part with index 0',
       description: 'This parts index is 0',
-      previewImageId: 'https://NER.com/zeroindexpart.jpg',
       status: 'IN_PROGRESS',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -158,7 +152,6 @@ const partIndexLarge = (projectId: string, userCreatedId: string, assigneeIds: s
       index: 99999999,
       commonName: 'Part with very large index',
       description: 'This part index is very large',
-      previewImageId: 'https://NER.com/largeindexpart.jpg',
       status: 'IN_PROGRESS',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -179,7 +172,6 @@ const partReadyForReview = (projectId: string, userCreatedId: string, assigneeId
       index: 9,
       commonName: 'Part with READY_FOR_REVIEW status',
       description: 'This part is ready for review',
-      previewImageId: 'https://NER.com/testimage.jpg',
       status: 'READY_FOR_REVIEW',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -200,7 +192,6 @@ const partInReview = (projectId: string, userCreatedId: string, assigneeIds: str
       index: 10,
       commonName: 'Part with IN_REVIEW status',
       description: 'This part is in review',
-      previewImageId: 'https://NER.com/testimage.jpg',
       status: 'IN_REVIEW',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -221,7 +212,6 @@ const partReviewed = (projectId: string, userCreatedId: string, assigneeIds: str
       index: 11,
       commonName: 'Part with REVIEWED status',
       description: 'This part is reviewed.',
-      previewImageId: 'https://NER.com/testimage.jpg',
       status: 'REVIEWED',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -242,7 +232,6 @@ const partApproved = (projectId: string, userCreatedId: string, assigneeIds: str
       index: 12,
       commonName: 'Part with APPROVED status',
       description: 'This part is approved.',
-      previewImageId: 'https://NER.com/testimage.jpg',
       status: 'APPROVED',
       createdAt: new Date('2025-01-01T10:00:00Z'),
       project: {
@@ -263,7 +252,6 @@ const partCurrentDate = (projectId: string, userCreatedId: string, assigneeIds:
       index: 13,
       commonName: 'Part with current date',
       description: 'This part has the current date.',
-      previewImageId: 'https://NER.com/testimage.jpg',
       status: 'APPROVED',
       createdAt: new Date(),
       project: {
@@ -284,7 +272,6 @@ const partPastDate = (projectId: string, userCreatedId: string, assigneeIds: str
       index: 14,
       commonName: 'Part with past date',
       description: 'This part is old.',
-      previewImageId: 'https://NER.com/testimage.jpg',
       status: 'APPROVED',
       createdAt: new Date('2000-01-01T00:00:00Z'),
       project: {
@@ -305,7 +292,6 @@ const partUnixEpochDate = (projectId: string, userCreatedId: string, assigneeIds
       index: 15,
       commonName: 'Part with date of Unix Epoch',
       description: 'This part is was made at the unix epoch.',
-      previewImageId: 'https://NER.com/testimage.jpg',
       status: 'APPROVED',
       createdAt: new Date('1970-01-01T00:00:00Z'),
       project: {
@@ -326,7 +312,6 @@ const partFutureDate = (projectId: string, userCreatedId: string, assigneeIds: s
       index: 16,
       commonName: 'Part with date of future',
       description: 'This part is was made in the future.',
-      previewImageId: 'https://NER.com/testimage.jpg',
       status: 'APPROVED',
       createdAt: new Date('2100-12-31T23:59:59Z'),
       project: {
@@ -347,7 +332,6 @@ const partLeapYearDate = (projectId: string, userCreatedId: string, assigneeIds:
       index: 17,
       commonName: 'Part with date with a leap year',
       description: 'This part is was during a leap year.',
-      previewImageId: 'https://NER.com/testimage.jpg',
       status: 'APPROVED',
       createdAt: new Date('2024-02-29T12:00:00Z'),
       project: {

src/backend/src/routes/parts.routes.ts

@@ -51,6 +51,8 @@ partsRouter.post(
   PartReviewController.updateReview
 );
 
+partsRouter.post('/review/:reviewId/delete', PartReviewController.deleteReview);
+
 partsRouter.post(
   '/submission/create',
   nonEmptyString(body('partId')),
@@ -164,50 +166,28 @@ partsRouter.post('/popup/:popupId/delete', PartReviewController.deletePartReview
 partsRouter.post('/reviewRequest/:reviewRequestId/delete', PartReviewController.deletePartReviewRequest);
 
 partsRouter.post(
-  '/:partId/reviewRequest/create',
+  '/notifyReviewer',
   nonEmptyString(body('reviewerId')),
+  nonEmptyString(body('partId')),
   validateInputs,
-  PartReviewController.createPartReviewRequest
+  PartReviewController.notifyReviewer
 );
-partsRouter.post('/reviewRequest/:reviewRequestId/delete', PartReviewController.deletePartReviewRequest);
-
-partsRouter.post('/:partId/upload-preview', upload.single('image'), PartReviewController.uploadPreview);
 
 partsRouter.post(
-  '/:partId/update',
-  intMinZero(body('index')),
-  nonEmptyString(body('commonName')),
-  body('description').optional().isString(),
-  body('reviewStatus').custom((value) => Object.values(Review_Status).includes(value)),
-  body('tagIds').isArray(),
-  body('assigneeIds').isArray(),
-  body('reviewerIds').isArray(),
+  '/notifyAssignee',
+  nonEmptyString(body('assigneeId')),
+  nonEmptyString(body('partId')),
   validateInputs,
-  PartReviewController.updatePart
+  PartReviewController.notifyAssignee
 );
 
-partsRouter.post('/:partId/delete', PartReviewController.deletePart);
-
-partsRouter.get('/:wbsNum', PartReviewController.getAllPartsForProject);
-
-partsRouter.post('/:partId/upload-preview', upload.single('image'), PartReviewController.uploadPreview);
-
 partsRouter.post(
-  '/:partId/update',
-  intMinZero(body('index')),
-  nonEmptyString(body('commonName')),
-  body('description').optional().isString(),
-  body('reviewStatus').custom((value) => Object.values(Review_Status).includes(value)),
-  body('tagIds').isArray(),
-  body('assigneeIds').isArray(),
+  '/:partId/reviewRequest/create',
+  nonEmptyString(body('reviewerId')),
   validateInputs,
-  PartReviewController.updatePart
+  PartReviewController.createPartReviewRequest
 );
 
-partsRouter.post('/:partId/delete', PartReviewController.deletePart);
-
-partsRouter.get('/:wbsNum', PartReviewController.getAllPartsForProject);
-
 partsRouter.post('/:partId/upload-preview', upload.single('image'), PartReviewController.uploadPreview);
 
 partsRouter.post(