Skip to content

#4269 event updating slack message#4277

Open
glickgNU wants to merge 6 commits into
developfrom
#4269-Event-Updating-Slack-Message
Open

#4269 event updating slack message#4277
glickgNU wants to merge 6 commits into
developfrom
#4269-Event-Updating-Slack-Message

Conversation

@glickgNU

Copy link
Copy Markdown
Contributor

Changes

Slack notifications have their times change accordingly with their respective events change time.

Test Cases

  • A scheduled event, when the time changes, the slack message changes time.
  • When other settings such as teams and name of event are changes, time still changes accordingly after these changes.

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4269

@staysgt staysgt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments, looks good so far!

Comment thread src/backend/src/services/calendar.services.ts Outdated
Comment thread src/backend/src/controllers/calendar.controllers.ts Outdated
Comment thread src/backend/src/services/calendar.services.ts Outdated

@staysgt staysgt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@staysgt staysgt requested a review from wavehassman June 15, 2026 22:48

@wavehassman wavehassman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall!
In editScheduleSlot service, add sendEventScheduledSlackNotif after the slot update (same pattern as editEvent already uses)
In editEvent service, make the Slack notification conditional on no slot changes being pending, so only one fires:

if (status === Event_Status.SCHEDULED && foundEventType.sendSlackNotifications && scheduleSlots.length === 0) {
  await sendEventScheduledSlackNotif(...);
}

optionalMembers: {
set: updatedOptionalMembers
},
scheduledTimes:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this use the editScheduleSlot service since it already updates the slots correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintenance] - Event Updating Slack Message

3 participants