fix: Game18NArguments deserialize, sayitemt redesign, pinit unknown, rc (#454)

- **Game18NArguments**: the class is a custom non-generic IList<object>,
  so the generic list path crashed with IndexOutOfRange on
  GetGenericArguments()[0] and couldn't assign a List<object> to it
  anyway. Special-case it in DeserializeValue to consume the remaining
  tokens directly. Fixes sayi / msgi / msgi2.
- **SayItemtPacket**: had four properties sharing [PacketIndex(3)] and
  [PacketIndex(4)], so deserialize put the character name into the
  Game18NConstString enum and threw "Requested value '<name>' was not
  found." Flattened to unique sequential indices and replaced the three
  typed sub-packet properties (IconInfo/EInfo/SlInfo) with a single
  string SubPacketRaw that captures the rest of the wire — only one
  of the four sub-packet shapes ever appears per packet so a typed
  poly field would need a real discriminator.
- **PinitSubPacket**: real wire carries 11 tokens
  (2|id|pos|level|name|-1|319|1|0|0|0) but schema had only 10 fields
  and the value 319 was landing on a byte Gender field. Inserted an
  Unknown2 int at index 6 so everything downstream (Gender/Race/Morph/
  HeroLevel) shifts one slot right.
- **RcPacket**: new class for `rc 1 14477871 11468 0`. Fields named
  Unknown1/Unknown2 until their semantics are RE'd.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: erwan-joly

documentation/DocumentationTest.PacketsDocumentation.verified.md

@@ -412,6 +412,7 @@
 - [npinfo](../src/NosCore.Packets/ServerPackets/Player/NpInfoPacket.cs) *InGame*
 - [p_sex](../src/NosCore.Packets/ServerPackets/Player/PSexPacket.cs) *InGame*
 - [rage](../src/NosCore.Packets/ServerPackets/Player/RagePacket.cs) *InGame*
+- [rc](../src/NosCore.Packets/ServerPackets/Player/RcPacket.cs) *InGame*
 - [rsfi](../src/NosCore.Packets/ServerPackets/Player/RsfiPacket.cs) *InGame*
 - [sc](../src/NosCore.Packets/ServerPackets/Player/ScPacket.cs) *InGame*
 - [scr](../src/NosCore.Packets/ServerPackets/Player/ScrPacket.cs) *InGame*

src/NosCore.Packets/Deserializer.cs

@@ -284,6 +284,20 @@ public IPacket Deserialize(string packetContent)
                 case var prop when (prop.BaseType?.Equals(typeof(Enum)) ?? false) ||
                     (Nullable.GetUnderlyingType(prop)?.IsEnum ?? false):
                     return DeserializeEnum(item1, matches[currentIndex++]);
+                case var prop when prop == typeof(Game18NArguments):
+                    // Game18NArguments is a custom non-generic IList<object>. The generic
+                    // list path can't figure out its element type (GetGenericArguments() is
+                    // empty) and can't assign List<object> to it, so sayi/msgi/msgi2 all
+                    // crashed with IndexOutOfRange. Consume the remaining tokens directly
+                    // into a fresh Game18NArguments; numeric tokens go in as long, the rest
+                    // as string.
+                    var g18n = new Game18NArguments(Math.Max(1, matches.Length - currentIndex));
+                    while (currentIndex < matches.Length)
+                    {
+                        var token = matches[currentIndex++];
+                        g18n.Add(long.TryParse(token, out var longValue) ? (object)longValue : token);
+                    }
+                    return g18n;
                 case var prop when typeof(ICollection).IsAssignableFrom(prop):
                     return DeserializeList(packetBasePropertyInfo.Item1.GetElementType() ?? packetBasePropertyInfo.Item1.GetGenericArguments()[0], packetBasePropertyInfo.Item2, matches, ref currentIndex, isMaxIndex);
                 case var prop when prop == typeof(IPacket):

src/NosCore.Packets/NosCore.Packets.csproj

@@ -12,7 +12,7 @@
 		<RepositoryUrl>https://github.com/NosCoreIO/NosCore.Packets.git</RepositoryUrl>
 		<PackageIconUrl></PackageIconUrl>
 		<PackageTags>nostale, noscore, chickenapi, nostale private server source, nostale emulator</PackageTags>
-		<Version>17.5.0</Version>
+		<Version>17.6.0</Version>
 		<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
 		<Description>NosCore's Packets (Nostale packets) defined over classes</Description>
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>

src/NosCore.Packets/ServerPackets/Chats/SayItemtPacket.cs

@@ -1,16 +1,24 @@
-//  __  _  __    __   ___ __  ___ ___
+//  __  _  __    __   ___ __  ___ ___
 // |  \| |/__\ /' _/ / _//__\| _ \ __|
 // | | ' | \/ |`._`.| \_| \/ | v / _|
 // |_|\__|\__/ |___/ \__/\__/|_|_\___|
 // -----------------------------------
 
 using NosCore.Packets.Attributes;
 using NosCore.Packets.Enumerations;
-using NosCore.Packets.ServerPackets.Inventory;
 using NosCore.Shared.Enumerations;
 
 namespace NosCore.Packets.ServerPackets.Chats
 {
+    /// <summary>
+    /// Chat bubble advertising a specific item/character, observed on the wire as:
+    /// <c>sayitemt 1 &lt;visualId&gt; &lt;oratorSlot&gt; &lt;type&gt; &lt;messageKey&gt; &lt;visualName&gt; &lt;argument&gt; &lt;subPacket...&gt;</c>
+    /// where <c>subPacket</c> is one of <c>IconInfo …</c>, <c>e_info …</c>,
+    /// <c>slinfo …</c> or <c>pslinfo …</c>. Because only one sub-packet shape
+    /// appears per wire line and the dispatch depends on the header token,
+    /// the whole tail is captured as a single raw string — consumers that need
+    /// structure should deserialise <see cref="SubPacketRaw"/> separately.
+    /// </summary>
     [PacketHeader("sayitemt", Scope.InGame)]
     public class SayItemtPacket : PacketBase
     {
@@ -29,20 +37,13 @@ public class SayItemtPacket : PacketBase
         [PacketIndex(4)]
         public Game18NConstString Message { get; set; }
 
-        [PacketIndex(4)]
+        [PacketIndex(5)]
         public string? VisualName { get; set; }
 
-        [PacketIndex(3, IsOptional = true)]
+        [PacketIndex(6, IsOptional = true)]
         public string? Argument { get; set; } = "{%s}";
 
-        [PacketIndex(4, IsOptional = true, RemoveHash = true)]
-        public IconInfoPacket? IconInfo { get; set; }
-
-        [PacketIndex(5, IsOptional = true, RemoveHash = true)]
-        public EInfoPacket? EquipmentInfo { get; set; }
-
-        [PacketIndex(6, IsOptional = true, RemoveHash = true)]
-        public SlInfoPacket? SlInfo { get; set; }
-
+        [PacketIndex(7, IsOptional = true)]
+        public string? SubPacketRaw { get; set; }
     }
-}
+}

src/NosCore.Packets/ServerPackets/Groups/PinitSubPacket.cs

@@ -34,15 +34,18 @@ public class PinitSubPacket : PacketBase
         public int Unknown { get; set; } //TODO: Find what this is made for
 
         [PacketIndex(6)]
-        public GenderType Gender { get; set; }
+        public int Unknown2 { get; set; } //TODO: Find what this is made for. Observed 319 on live wire, shifts Gender/Race/Morph/HeroLevel by one.
 
         [PacketIndex(7)]
-        public short Race { get; set; }
+        public GenderType Gender { get; set; }
 
         [PacketIndex(8)]
-        public short Morph { get; set; }
+        public short Race { get; set; }
 
         [PacketIndex(9)]
+        public short Morph { get; set; }
+
+        [PacketIndex(10)]
         public byte HeroLevel { get; set; }
     }
 }

src/NosCore.Packets/ServerPackets/Player/RcPacket.cs

@@ -0,0 +1,31 @@
+//  __  _  __    __   ___ __  ___ ___
+// |  \| |/__\ /' _/ / _//__\| _ \ __|
+// | | ' | \/ |`._`.| \_| \/ | v / _|
+// |_|\__|\__/ |___/ \__/\__/|_|_\___|
+// -----------------------------------
+
+using NosCore.Packets.Attributes;
+using NosCore.Packets.Enumerations;
+
+namespace NosCore.Packets.ServerPackets.Player
+{
+    /// <summary>
+    /// Server-side compact packet observed as <c>rc 1 14477871 11468 0</c>.
+    /// Fields are unnamed until the semantics are reverse-engineered.
+    /// </summary>
+    [PacketHeader("rc", Scope.InGame)]
+    public class RcPacket : PacketBase
+    {
+        [PacketIndex(0)]
+        public byte Type { get; set; }
+
+        [PacketIndex(1)]
+        public long VisualId { get; set; }
+
+        [PacketIndex(2)]
+        public int Unknown1 { get; set; }
+
+        [PacketIndex(3)]
+        public int Unknown2 { get; set; }
+    }
+}