Merged
Conversation
Contributor
erwan-joly
commented
Nov 15, 2025
erwan-joly
commented
- Updated all project files from net8.0 to net10.0
- Updated GitHub Actions workflow to use .NET 10.0.x
- Updated Microsoft.Extensions.Hosting from 8.0.0 to 10.0.0
- Updated Microsoft.Extensions.Http from 8.0.0 to 10.0.0
- Updated all project files from net8.0 to net10.0 - Updated GitHub Actions workflow to use .NET 10.0.x - Updated Microsoft.Extensions.Hosting from 8.0.0 to 10.0.0 - Updated Microsoft.Extensions.Http from 8.0.0 to 10.0.0
- Microsoft.NET.Test.Sdk: 17.8.0 → 17.12.0 - MSTest.TestAdapter: 3.1.1 → 3.6.3 - MSTest.TestFramework: 3.1.1 → 3.6.3 - coverlet.collector: 6.0.0 → 6.0.2 - Serilog: 3.1.1 → 4.2.0
- Updated actions/checkout from v2 to v4 - Updated actions/setup-dotnet from v3 to v4 - Replaced deprecated ::set-output with $GITHUB_OUTPUT - Replaced deprecated actions/upload-release-asset@v1 with softprops/action-gh-release@v2 - Removed jossef/action-latest-release-info action (no longer needed)
- Added NoWarn directive for MSTEST0037 to prevent build errors - This analyzer rule suggests using Assert.AreEqual instead of Assert.IsTrue for equality checks - Currently no violations exist in the codebase, but this prevents future build failures
- No Assert.IsTrue violations exist in the codebase - The test file only contains an empty test method - Project should build cleanly without suppression
- Removed NoWarn directive for CS1591 (missing XML documentation) - Project will now enforce XML documentation comments on all public APIs
Added comprehensive XML documentation comments to all public types, methods, properties, and members across the codebase to satisfy CS1591 requirements: - Downloader: IClientDownloader, ClientDownloader, ClientManifest, Entry - Extractor: IExtractor, Extractor - I18N: LogLanguage, LogLanguageKey - Launcher: Program, Worker, ParserInputGeneratorConfiguration This ensures the project builds cleanly with GenerateDocumentationFile enabled and TreatWarningsAsErrors set to true.
- Updated actions/checkout from v4 to v5 - Updated actions/setup-dotnet from v4 to v5 - Quoted dotnet-version for better YAML compatibility - Ensures compatibility with .NET 10 (released November 11, 2025)
Main project packages: - Serilog: 4.2.0 → 4.3.0 - Serilog.Extensions.Hosting: 8.0.0 → 9.0.0 Test project packages: - Microsoft.NET.Test.Sdk: 17.12.0 → 18.0.1 - MSTest.TestAdapter: 3.6.3 → 4.0.2 - MSTest.TestFramework: 3.6.3 → 4.0.2 - coverlet.collector: 6.0.2 → 6.0.4 All packages are now at their latest stable versions as of November 2025.
Added explicit package references to override vulnerable transitive dependencies: - Microsoft.IdentityModel.JsonWebTokens: 8.2.1 (fixes GHSA-59j7-ghrg-fj52 / CVE-2024-21319) - System.IdentityModel.Tokens.Jwt: 8.2.1 (fixes GHSA-59j7-ghrg-fj52 / CVE-2024-21319) These packages override the vulnerable 7.0.3 versions that were coming from transitive dependencies. The vulnerability (CVE-2024-21319) is a Denial of Service issue affecting JWT-based authentication tokens, allowing unauthenticated clients to consume excessive server memory.
Added assembly-level Parallelize attribute to fix MSTEST0001 analyzer error. Tests will run sequentially (Workers = 0) for safe and predictable execution. This is required by MSTest 4.0+ analyzers.
erwan-joly
deleted the
claude/upgrade-dotnet-10-01Wxr163GGMrogYztojcys1T
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.