fix #84 rename length

Author: erwan-joly

src/NosCore.PathFinder.Gui/Dtos/MapDto.cs

@@ -38,7 +38,7 @@ public short Width
             }
         }
 
-        public short Length
+        public short Height
         {
             get
             {
@@ -58,7 +58,7 @@ public short Length
 
         public bool IsWalkable(short mapX, short mapY)
         {
-            if ((mapX >= Width) || (mapX < 0) || (mapY >= Length) || (mapY < 0))
+            if ((mapX >= Width) || (mapX < 0) || (mapY >= Height) || (mapY < 0))
             {
                 return false;
             }

src/NosCore.PathFinder.Gui/GuiWindow.cs

@@ -46,7 +46,7 @@ public class GuiWindow : GameWindow
         private Dictionary<Color, Vector2[]>? _brushFirePixels;
 
         public GuiWindow(MapDto map, int width, int height, string title, DataAccessHelper dbContextBuilder)
-            : base(width, (height < width / map.Width * map.Length) ? width / map.Width * map.Length : height,
+            : base(width, (height < width / map.Width * map.Height) ? width / map.Width * map.Height : height,
                 GraphicsMode.Default, title)
         {
             var dbContextBuilder1 = dbContextBuilder;
@@ -86,7 +86,7 @@ public GuiWindow(MapDto map, int width, int height, string title, DataAccessHelp
             Parallel.ForEach(_npcs, npc => _ = npc.StartLife(CancellationToken.None));
 
             var wallpixels = new List<Vector2[]>();
-            for (short y = 0; y < _map.Length; y++)
+            for (short y = 0; y < _map.Height; y++)
             {
                 for (short x = 0; x < _map.Width; x++)
                 {

src/NosCore.PathFinder.Gui/PathfinderGui.cs

@@ -49,7 +49,7 @@ public static async Task Main(string[] args)
                 }
                 var map = await mapDao.FirstOrDefaultAsync(m => m.MapId == askMapId).ConfigureAwait(false);
 
-                if ((!(map?.Width > 0)) || (map.Length <= 0))
+                if ((!(map?.Width > 0)) || (map.Height <= 0))
                 {
                     continue;
                 }

src/NosCore.PathFinder/Brushfire/IMapGridExtension.cs

@@ -25,7 +25,7 @@ public static class IMapGridExtension
                 var currentX = (short)(cell.X + delta.X);
                 var currentY = (short)(cell.Y + delta.Y);
                 return currentX >= 0 && currentX < grid.Width &&
-                        currentY >= 0 && currentY < grid.Length &&
+                        currentY >= 0 && currentY < grid.Height &&
                         (includeWalls || grid.IsWalkable(currentX, currentY)
                         );
             }).Select(delta => ((short)(cell.X + delta.X), (short)(cell.Y + delta.Y)));
@@ -34,14 +34,14 @@ public static class IMapGridExtension
         public static BrushFire LoadBrushFire(this IMapGrid mapGrid, (short X, short Y) user, IHeuristic heuristic, short maxDistance = 22)
         {
             if (user.X < 0 || user.X >= mapGrid.Width ||
-                user.Y < 0 || user.Y >= mapGrid.Length)
+                user.Y < 0 || user.Y >= mapGrid.Height)
             {
-                return new BrushFire(user, new Dictionary<(short X, short Y), Node?>(), mapGrid.Width, mapGrid.Length);
+                return new BrushFire(user, new Dictionary<(short X, short Y), Node?>(), mapGrid.Width, mapGrid.Height);
             }
 
             var path = new MinHeap();
             var cellGrid = new Dictionary<(short X, short Y), Node?>();
-            var grid = new Node?[mapGrid.Width, mapGrid.Length];
+            var grid = new Node?[mapGrid.Width, mapGrid.Height];
             grid[user.X, user.Y] = new Node(user, mapGrid[user.X, user.Y])
             {
                 Closed = true
@@ -82,7 +82,7 @@ public static BrushFire LoadBrushFire(this IMapGrid mapGrid, (short X, short Y)
                     neighbors[i]!.Closed = true;
                 }
             }
-            return new BrushFire(user, cellGrid, mapGrid.Width, mapGrid.Length);
+            return new BrushFire(user, cellGrid, mapGrid.Width, mapGrid.Height);
         }
 
     }

src/NosCore.PathFinder/Interfaces/IMapGrid.cs

@@ -9,8 +9,8 @@ namespace NosCore.PathFinder.Interfaces
     public interface IMapGrid
     {
         public short Width { get; }
-        public short Length { get; }
+        public short Height { get; }
         public byte this[short x, short y] { get; }
         bool IsWalkable(short currentX, short currentY);
     }
-}
+} 

src/NosCore.PathFinder/Pathfinder/JumpPointSearchPathfinder.cs

@@ -74,7 +74,7 @@ public JumpPointSearchPathfinder(IMapGrid mapGrid, IHeuristic heuristic)
 
         internal IEnumerable<(short X, short Y)> GetJumpList((short X, short Y) start, (short X, short Y) end)
         {
-            var nodes = new JumpNode?[_mapGrid.Width, _mapGrid.Length];
+            var nodes = new JumpNode?[_mapGrid.Width, _mapGrid.Height];
             if (_mapGrid.IsWalkable(start.X, start.Y) && _mapGrid.IsWalkable(end.X, end.Y))
             {
                 var startNode = new JumpNode(start, _mapGrid[start.X, start.Y]) { F = 0, G = 0, Opened = true };

test/NosCore.PathFinder.Tests/BrushFireTests.cs

@@ -23,13 +23,13 @@ public void Test_BrushFire()
         {
             (short X, short Y) characterPosition = (6, 10);
             var brushFire = _map.LoadBrushFire(characterPosition, new OctileDistanceHeuristic());
-            var bitmap = new Bitmap(_map.Width * TestHelper.Scale, _map.Length * TestHelper.Scale);
+            var bitmap = new Bitmap(_map.Width * TestHelper.Scale, _map.Height * TestHelper.Scale);
             var listPixel = new List<Color>();
             TestHelper.DrawMap(_map, TestHelper.Scale, listPixel, bitmap, (0, 0), characterPosition);
             using var graphics = Graphics.FromImage(bitmap);
 
 
-            for (short y = 0; y < _map.Length; y++)
+            for (short y = 0; y < _map.Height; y++)
             {
                 for (short x = 0; x < _map.Width; x++)
                 {

test/NosCore.PathFinder.Tests/GoalBasedPathfinderTests.cs

@@ -35,14 +35,14 @@ public GoalBasedPathfinderTests()
         [TestMethod]
         public void Test_GoalBasedPathfinder()
         {
-            var bitmap = new Bitmap(_map.Width * TestHelper.Scale, _map.Length * TestHelper.Scale);
+            var bitmap = new Bitmap(_map.Width * TestHelper.Scale, _map.Height * TestHelper.Scale);
             (short X, short Y) target = (15, 16);
             var listPixel = new List<Color>();
             TestHelper.DrawMap(_map, TestHelper.Scale, listPixel, bitmap, target, _characterPosition);
             using var graphics = Graphics.FromImage(bitmap);
 
 
-            for (short y = 0; y < _map.Length; y++)
+            for (short y = 0; y < _map.Height; y++)
             {
                 for (short x = 0; x < _map.Width; x++)
                 {

test/NosCore.PathFinder.Tests/JumpPointSearchPathfinderTests.cs

@@ -31,7 +31,7 @@ public JumpPointSearchPathfinderTests()
         [TestMethod]
         public void Test_JumpPointSearchPathfinder()
         {
-            var bitmap = new Bitmap(_map.Width * TestHelper.Scale, _map.Length * TestHelper.Scale);
+            var bitmap = new Bitmap(_map.Width * TestHelper.Scale, _map.Height * TestHelper.Scale);
             (short X, short Y) target = (15, 16);
             var listPixel = new List<Color>();
             TestHelper.DrawMap(_map, TestHelper.Scale, listPixel, bitmap, target, _characterPosition);

test/NosCore.PathFinder.Tests/TestHelper.cs

@@ -71,7 +71,7 @@ public static void VerifyFile(string linearPathfinderPng, Bitmap bitmap, List<Co
         public static void DrawMap(TestMap map, int scale, List<Color> listPixel, Bitmap bitmap, (short X, short Y) monster, (short X, short Y) character)
         {
             using var graphics = Graphics.FromImage(bitmap);
-            for (short y = 0; y < map.Length; y++)
+            for (short y = 0; y < map.Height; y++)
             {
                 for (short x = 0; x < map.Width; x++)
                 {