Skip to content
This repository was archived by the owner on Dec 11, 2025. It is now read-only.

Commit 3c6fc5b

Browse files
committed
chore: comment out support tools for gpt 4.5 and refactor skip condition
1 parent bc32d0d commit 3c6fc5b

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

notdiamond/settings.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,9 @@
6363
"gpt-4-turbo-preview",
6464
"gpt-4-0125-preview",
6565
"gpt-4-1106-preview",
66+
# Need to update langchain-openai to >=0.3.9 to support these
67+
# "gpt-4.5-preview",
68+
# "gpt-4.5-preview-2025-02-27"
6669
],
6770
"support_response_model": [
6871
"gpt-3.5-turbo",

tests/test_llm_calls/test_openai.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,8 @@ def test_streaming_use_stop(self, prompt, provider):
4141
assert chunk.content != "a"
4242

4343
def test_with_tool_calling(self, tools_fixture, provider):
44-
if (
45-
provider.model == "chatgpt-4o-latest"
46-
or provider.model == "gpt-4.5-preview"
47-
or provider.model == "gpt-4.5-preview-2025-02-27"
44+
if provider.model == "chatgpt-4o-latest" or provider.model.startswith(
45+
"gpt-4.5"
4846
):
4947
return
5048

@@ -60,10 +58,8 @@ def test_with_tool_calling(self, tools_fixture, provider):
6058
assert result.tool_calls[0]["name"] == "add_fct"
6159

6260
def test_with_openai_tool_calling(self, openai_tools_fixture, provider):
63-
if (
64-
provider.model == "chatgpt-4o-latest"
65-
or provider.model == "gpt-4.5-preview"
66-
or provider.model == "gpt-4.5-preview-2025-02-27"
61+
if provider.model == "chatgpt-4o-latest" or provider.model.startswith(
62+
"gpt-4.5"
6763
):
6864
return
6965

0 commit comments

Comments
 (0)