ENG-2299: Deprecate OpenAI o1 preview and OpenAI o1 mini#97
Conversation
- Deleted O1 model entries from the PROVIDERS in settings.py. - Removed is_o1_model function and related logic from client.py and providers.py. - Deleted tests and cassettes related to O1 models to clean up the codebase.
…d client - Deleted the o1_system_prompt_translate function from prompts.py. - Removed references to the O1 model translation in client.py to streamline the codebase.
| "ChatOpenAI", | ||
| provider.provider, | ||
| ) | ||
| if is_o1_model(provider): |
There was a problem hiding this comment.
do the new O models support temperature or other reasoning models for that matter?
There was a problem hiding this comment.
in this check from what I see we checked only o1 models (preview and mini), we don't have any O models within this one 🤷
There was a problem hiding this comment.
Ok actually I recall temperature is no longer a param in the newer models, we can just remove this check and expect the user to get an error if they specify temperature
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "ChatOpenAI", | ||
| provider.provider, | ||
| ) | ||
| if is_o1_model(provider): |
There was a problem hiding this comment.
Ok actually I recall temperature is no longer a param in the newer models, we can just remove this check and expect the user to get an error if they specify temperature
2 participants
No description provided.