builtin angular treesitter + conform support

[sand4rt]

I have verified that this feature request has not been made before

• I have checked the issues tab, and did not find a similar feature request. I understand that my issue will be closed if it is a duplicate.

Feature Type

Update Request (Plugin/Nixpkgs)

Feature description

syntax highlighting in the template strings is not enabled:
https://github.com/NotAShelf/nvf/blob/main/modules/plugins/lsp/presets/angular-language-server.nix

import { Component, resource } from '@angular/core';

@Component({
  selector: 'app-list',
  template: `
    @if (items.isLoading()) {
      <p>loading</p>
    } @else if (items.error()) {
      <p>failed to load items</p>
    } @else {
      <ul>
        @for (item of items.value(); track item.id) {
          <li>{{ item.label }}</li>
        }
      </ul>
    }
  `,
})
export class ListComponent {
  items = resource({
    loader: async () => [{ label: 'test' }],
    defaultValue: [],
  });
}

Alternatives

enabling manually:

programs.nvf.settings.vim.treesitter.grammars = with pkgs.vimPlugins.nvim-treesitter-parsers; [
  angular
];

Additional Context

conform integration was missing too. See lazyvim examle for an example: https://github.com/LazyVim/LazyVim/blob/main/lua/lazyvim/plugins/extras/lang/angular.lua

{  
    "conform.nvim",
    opts = function(_, opts)
      if LazyVim.has_extra("formatting.prettier") then
        opts.formatters_by_ft = opts.formatters_by_ft or {}
        opts.formatters_by_ft.htmlangular = { "prettier" }
      end
    end,
  }

[snoweuph]

What does

programs.nvf.settings.vim.treesitter.grammars = with pkgs.vimPlugins.nvim-treesitter-parsers; [
  angular
];

Actually do 🤔

Sounds to me like it just adds 1 Injection and nothing else...

---

Edit, reminds me that it also contains htmlangular which basically is just the @if syntax with injections for html.

FYI: my config rn:

{pkgs, ...}: {
  vim = {
    lsp = {
      presets = {
        angular-language-server.enable = true;
        emmet-ls.enable = true;
      };
      servers = {
        angular-language-server.filetypes = ["htmlangular"];
        emmet-ls.filetypes = ["htmlangular"];
      };
    };
    treesitter.grammars = [pkgs.vimPlugins.nvim-treesitter-parsers.angular];
    languages = {
      typescript.lsp.servers = [
        "angular-language-server"
      ];
    };
  };
}

And Ive added the Parent Issue, where we are already talking about creating a full language module.

[sand4rt]

What does

programs.nvf.settings.vim.treesitter.grammars = with pkgs.vimPlugins.nvim-treesitter-parsers; [
angular
];
Actually do 🤔

Sounds to me like it just adds 1 Injection and nothing else...

It turned on the syntax highlighting in template strings:

@Component({
  selector: 'app-list',
  template: ` THIS SYNTAX HERE `

[snoweuph]

What does
programs.nvf.settings.vim.treesitter.grammars = with pkgs.vimPlugins.nvim-treesitter-parsers; [
angular
];
Actually do 🤔
Sounds to me like it just adds 1 Injection and nothing else...

It turned on the syntax highlighting in template strings:

@component({
selector: 'app-list',
template: THIS SYNTAX HERE

Thats what I said.
In treesitter it is an Injectionm, that basically says:
use the parser X for this part of the Nodes.
They are called Injections

We are also doing them in NVF https://github.com/NotAShelf/nvf/blob/main/modules/plugins/languages/nix.nix#L134

[sand4rt]

Ah i see, does it make sense to enable this by default when: vim.lsp.presets.angular-language-server.enable = true; ?

[snoweuph]

Ah i see, does it make sense to enable this by default when: vim.lsp.presets.angular-language-server.enable = true; ?

No.
The LSP presets are supposed to stay pure.

#1575 (The Issue I added as a parent) is about doing some refactoring, resulting in languages.angular as a module