Skip to content

rich-presence/cord-nvim: init#1519

Open
adam01110 wants to merge 1 commit into
NotAShelf:mainfrom
adam01110:feat/cord-nvim
Open

rich-presence/cord-nvim: init#1519
adam01110 wants to merge 1 commit into
NotAShelf:mainfrom
adam01110:feat/cord-nvim

Conversation

@adam01110

@adam01110 adam01110 commented Apr 14, 2026

Copy link
Copy Markdown

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown

🚀 Live preview deployed from 18d2d23

View it here:

Debug Information

Triggered by: adam01110

HEAD at: feat/cord-nvim

Reruns: 3384

@adam01110 adam01110 changed the title rich-presence/cord: init rich-presence/cord-nvim: init Apr 14, 2026

@NotAShelf NotAShelf left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I left too small comments to be addressrd before we can merge. I also would like to know if this could be lazy-loaded, probably on DeferredUIEnter? Would be great if you could check, but it is fine as is.

Comment thread modules/plugins/rich-presence/cord-nvim/config.nix Outdated
Comment thread modules/plugins/rich-presence/cord-nvim/cord.nix Outdated
github-actions Bot pushed a commit that referenced this pull request Apr 16, 2026
@adam01110 adam01110 force-pushed the feat/cord-nvim branch 3 times, most recently from 16e6537 to d27aec6 Compare April 16, 2026 21:55
github-actions Bot pushed a commit that referenced this pull request Apr 16, 2026
@adam01110

adam01110 commented Apr 16, 2026

Copy link
Copy Markdown
Author

Sorry for the force-pushes, my formatter kept changing the codewindow.nvim release notes entry.

@snoweuph

Copy link
Copy Markdown
Collaborator

should prolly be added in configuration.nix as enabled = false just like neocord

github-actions Bot pushed a commit that referenced this pull request Apr 18, 2026
github-actions Bot pushed a commit that referenced this pull request Apr 18, 2026
@adam01110 adam01110 requested a review from snoweuph as a code owner April 27, 2026 14:04
github-actions Bot pushed a commit that referenced this pull request Apr 27, 2026
github-actions Bot pushed a commit that referenced this pull request Jun 5, 2026
@adam01110 adam01110 requested a review from NotAShelf June 5, 2026 20:31
@snoweuph

snoweuph commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Sorry for the force-pushes, my formatter kept changing the codewindow.nvim release notes entry.

Its fine, I personally use rebase + force-with-lease alot.

Also its nice when the commits are in style.
(Raf prefers that as well)

snoweuph
snoweuph previously approved these changes Jun 5, 2026

@snoweuph snoweuph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But needs final review from raf to be merged

Soliprem
Soliprem previously approved these changes Jun 9, 2026
@snoweuph snoweuph enabled auto-merge June 10, 2026 18:33
auto-merge was automatically disabled June 30, 2026 17:00

Head branch was pushed to by a user without write access

@adam01110 adam01110 dismissed stale reviews from Soliprem and snoweuph via 7c29a1d June 30, 2026 17:00
github-actions Bot pushed a commit that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants