wrapper: expose appName in mnw via config.vim.appname#1634
Conversation
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I993291328809699680c4765ea6313d996a6a6964
the easiest solution is to just create a in other news, I should swap vim.lazy.packages to use https://gerg-l.github.io/mnw/options.html#plugins.optAttrs and lift the stupid "attr name must equal package name" restriction |
snoweuph
left a comment
There was a problem hiding this comment.
I like this.
just misses some changelog xD
|
why would you need a changelog entry for a new feature? |
@NotAShelf should just work the other option would be to convert nvf into a mnwModule and leave the current mnw options as-is and just wrap the mnw functions/modules with injecting nvf into them |
Because an Addition is also a change. |
seems a bit annoying to do tbh |
Fixes the hardcoded appname in the build wrapper. I've noticed that the way we set wrapper options is a bit... messy. We have
vim.build, but it's used only forfinalPackage. I'd like to establish a naming convention with @horriblename, @snoweuph and @Soliprem so this PR can be repurposed as a general-purpose wrapper refactoring one. Alternatively we should allow additional args to be passed to mnw. Maybe @Gerg-L can chime in on that. Recursive merge? Just//?