removed windows binary runner, fixes to c++ standards, and restructured ci/cd pipeline

Author: kernelwernel

.clang-tidy

@@ -13,6 +13,9 @@ Checks: >
     -readability-avoid-unconditional-preprocessor-if,
     -readability-use-concise-preprocessor-directives,
     -readability-redundant-typename,
+    -readability-enum-initial-value,
+    -readability-container-contains,
+    -readability-container-data-pointer,
     clang-analyzer-*,
     bugprone-*,
     -bugprone-easily-swappable-parameters,
@@ -25,18 +28,18 @@ Checks: >
     portability-*,
     modernize-*,
     -modernize-use-trailing-return-type,
-    -modernize-use-nullptr,
+    -modernize-use-nullptr, 
     -modernize-use-override,
     -modernize-use-default-member-init,
     -modernize-use-ranges,
+    -modernize-use-starts-with,
     -modernize-use-designated-initializers,
     -modernize-use-nodiscard,
     -modernize-use-auto,
     -modernize-avoid-c-arrays,
     -modernize-use-constraints,
     -modernize-type-traits,
     cppcoreguidelines-*,
-    -readability-enum-initial-value,
     -cppcoreguidelines-avoid-magic-numbers,
     -cppcoreguidelines-pro-bounds-pointer-arithmetic,
     -cppcoreguidelines-pro-bounds-array-to-pointer-decay,

.github/workflows/build_run_win_32_debug.bat

@@ -4,6 +4,4 @@ mkdir build
 cd build
 cmake -DDEBUG_OUTPUT=ON -G "Visual Studio 17 2022" -A Win32 -S ..
 "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.com" "VMAware.sln" /Build "Release|Win32" /Project "vmaware" /ProjectConfig "Release|Win32"
-cd Release
-vmaware.exe
 exit /b 0

.github/workflows/build_run_win_32_release.bat

@@ -4,6 +4,4 @@ mkdir build
 cd build
 cmake -G "Visual Studio 17 2022" -A Win32 -S ..
 "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.com" "VMAware.sln" /Build "Release|Win32" /Project "vmaware" /ProjectConfig "Release|Win32"
-cd Release
-vmaware.exe
 exit /b 0

.github/workflows/build_run_win_64_debug.bat

@@ -4,6 +4,4 @@ mkdir build
 cd build
 cmake -DDEBUG_OUTPUT=ON -G "Visual Studio 17 2022" -A x64 -S ..
 "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.com" "VMAware.sln" /Build "Release|x64" /Project "vmaware" /ProjectConfig "Release|x64"
-cd Release
-vmaware.exe
 exit /b 0

.github/workflows/build_run_win_64_release.bat

@@ -4,6 +4,4 @@ mkdir build
 cd build
 cmake -G "Visual Studio 17 2022" -A x64 -S ..
 "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.com" "VMAware.sln" /Build "Release|x64" /Project "vmaware" /ProjectConfig "Release|x64"
-cd Release
-vmaware.exe
 exit /b 0

.github/workflows/cross-platform-build.yml

@@ -79,15 +79,6 @@ jobs:
               cmake --build build --config Release
             "
 
-      - name: Run binary (${{ matrix.arch }})
-        run: |
-          docker run --rm \
-            --platform ${{ matrix.platform }} \
-            -v ${{ github.workspace }}:/src \
-            -w /src \
-            ${{ matrix.image }} \
-            ./build/vmaware
-
       - name: Upload binary artifact
         uses: actions/upload-artifact@v4
         with:
@@ -118,9 +109,6 @@ jobs:
       - name: Build
         run: cmake --build build --config Release
 
-      - name: Run binary
-        run: build/vmaware
-
       - name: Upload binary artifact
         uses: actions/upload-artifact@v4
         with:
@@ -213,7 +201,7 @@ jobs:
         run: cmake --build build --config Release
 
   all-platforms:
-    needs: [linux, macos, windows, cli-test, cpp-standard]
+    needs: [cli-test, cpp-standard]
     runs-on: ubuntu-latest
     steps:
       - run: echo "All platforms built successfully"

src/vmaware.hpp

@@ -3639,7 +3639,7 @@ struct VM {
             print_to_stream(ss, std::forward<Args>(message)...);
             std::string msg_content = ss.str();
 
-            if (!printed_messages.contains(msg_content)) {
+            if (printed_messages.find(msg_content) == printed_messages.end()) {
             #if (LINUX || APPLE)
                 constexpr const char* black_bg = "\x1B[48;2;0;0;0m";
                 constexpr const char* bold = "\033[1m";
@@ -4925,7 +4925,7 @@ struct VM {
         const std::string& brand = cpu::get_brand();
 
         // easy shortcut for QEMU
-        if (brand.starts_with("QEMU Virtual CPU version")) {
+        if (brand.rfind("QEMU Virtual CPU version", 0) == 0) {
             return core::add(brand_enum::QEMU);
         }
 
@@ -6859,7 +6859,7 @@ struct VM {
                 continue;
             }
 
-            char* data = content.data();
+            char* data = &content[0];
             const size_t len = content.size();
 
             for (size_t i = 0; i < len; ++i) {
@@ -7068,7 +7068,7 @@ struct VM {
         bool ppid_match = false;
 
         auto parse_number = [&](const std::string& prefix) -> int {
-            if (!line.starts_with(prefix)) {
+            if (line.rfind(prefix, 0) != 0) {
                 return -1;
             }
 
@@ -7480,7 +7480,7 @@ struct VM {
         return core::add(brand_enum::AZURE_HYPERV);
     }
     template <typename T, size_t N>
-    constexpr bool check_no_nulls(const std::array<T, N>& arr, size_t i = 0) {
+    constexpr bool check_no_nulls(const std::array<T, N>& arr, size_t i = 0) const {
         return (i == N)
             ? true
             : (arr[i] != nullptr && check_no_nulls(arr, i + 1));
@@ -13209,8 +13209,8 @@ struct VM {
         };
 
         // entry for the initialization list
-        struct technique_entry {
-            enum_flags id = enum_flags::NULL_ARG;
+        struct technique_entry { // NOLINT(cppcoreguidelines-pro-type-member-init)
+            enum_flags id;
             technique tech;
         };
 
@@ -13624,12 +13624,6 @@ struct VM {
             throw_error("Flag argument must be a technique flag and not a settings flag");
         }
 
-        #if (MSVC && !CLANG)
-            __assume(flag_bit < technique_end);
-        #elif (VMA_CPP >= 23)
-            [[assume(flag_bit < technique_end)]];
-        #endif
-
         // if the technique is already cached, return the cached value instead
         if (memo::is_cached(flag_bit)) {
             const memo::data_t data = memo::cache_fetch(flag_bit);
@@ -13817,12 +13811,6 @@ struct VM {
         if (percent > 100) {
             throw_error("Percentage parameter must be between 0 and 100");
         }
-        
-        #if (MSVC && !CLANG)
-            __assume(percent > 0 && percent <= 100);
-        #elif (VMA_CPP >= 23)
-            [[assume(percent > 0 && percent <= 100)]];
-        #endif
 
         const size_t current_index = core::custom_table.size();