fix(network): give DHCP server its own graph icon, distinct from cluster#547
Conversation
review) On the graph canvas dhcp-server and cluster both rendered bi-diagram-3 (), so a DHCP server node was indistinguishable from a cluster node. The codepoint wasn't drifted — it faithfully matched NODE_TYPE_CONFIG's 'bi-diagram-3' class — so fixing it means changing the class name too, or the iconCodepoints test (which enforces codepoint == config class) fails. Point dhcp-server at bi-broadcast () in both the config and the codepoint table; cluster keeps bi-diagram-3. Broadcast also fits DHCP's DISCOVER/OFFER semantics, and no other node type uses it. 40 icon tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the icon for the DHCP server node from 'bi-diagram-3' to 'bi-broadcast' (unicode '\uf1d6') in both the network graph node icons and the network feature constants to ensure visual consistency. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Problem
On the network graph canvas,
dhcp-serverandclusterboth renderedbi-diagram-3(), so a DHCP server node was visually indistinguishable from a cluster node. Flagged by gemini during review of #546.Why it's not a one-line codepoint swap
iconCodepoints.test.tsenforces thatNODE_TYPE_ICONS[nodeType]equals the codepoint ofNODE_TYPE_CONFIG[nodeType].icon(the class name the legend renders from). Thecodepoint was not drifted — it faithfully matched the config's'bi-diagram-3'. So changing only the codepoint would break that test. The fix has to move the class name too.Change
Point
dhcp-serveratbi-broadcast() in both places:features/network/constants.ts—NODE_TYPE_CONFIGicon class (drives the legend)components/network/NetworkGraph/nodeIcons.ts— the WebGL codepoint tableclusterkeepsbi-diagram-3, so the collision is resolved.bi-broadcastalso fits DHCP's DISCOVER/OFFER broadcast semantics, and no other node type uses it.Verification
iconCodepoints.test.ts— 40 passed (incl. theNODE_TYPE_ICONS == NODE_TYPE_CONFIGinvariant fordhcp-server).Follow-up to a review comment on #546; independent of that PR (main-based, frontend-only).
🤖 Generated with Claude Code