From 445213a9dfecd37da047377181abef6af3fba4be Mon Sep 17 00:00:00 2001
From: notyusheng <notyusheng@gmail.com>
Date: Sun, 19 Jul 2026 03:51:51 +0800
Subject: [PATCH] fix(network): give DHCP server its own icon, distinct from
 cluster (#496 review)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On the graph canvas dhcp-server and cluster both rendered bi-diagram-3
(), so a DHCP server node was indistinguishable from a cluster node.
The codepoint wasn't drifted — it faithfully matched NODE_TYPE_CONFIG's
'bi-diagram-3' class — so fixing it means changing the class name too, or
the iconCodepoints test (which enforces codepoint == config class) fails.

Point dhcp-server at bi-broadcast () in both the config and the
codepoint table; cluster keeps bi-diagram-3. Broadcast also fits DHCP's
DISCOVER/OFFER semantics, and no other node type uses it. 40 icon tests pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 frontend/src/components/network/NetworkGraph/nodeIcons.ts | 2 +-
 frontend/src/features/network/constants.ts                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/network/NetworkGraph/nodeIcons.ts b/frontend/src/components/network/NetworkGraph/nodeIcons.ts
index 9ca7bfb9..514f09df 100644
--- a/frontend/src/components/network/NetworkGraph/nodeIcons.ts
+++ b/frontend/src/components/network/NetworkGraph/nodeIcons.ts
@@ -19,7 +19,7 @@ export const NODE_TYPE_ICONS: Record<string, string> = {
   'ssh-server':      '\uf5c3', // bi-terminal
   'ftp-server':      '\uf3d5', // bi-folder-symlink
   'mail-server':     '\uf32f', // bi-envelope
-  'dhcp-server':     '\uf2ee', // bi-diagram-3
+  'dhcp-server':     '\uf1d6', // bi-broadcast
   'ntp-server':      '\uf293', // bi-clock
   'database-server': '\uf8c4', // bi-database
   router:            '\uf6ec', // bi-router
diff --git a/frontend/src/features/network/constants.ts b/frontend/src/features/network/constants.ts
index 77ea973d..3dd18f2d 100644
--- a/frontend/src/features/network/constants.ts
+++ b/frontend/src/features/network/constants.ts
@@ -55,7 +55,7 @@ export const NODE_TYPE_CONFIG: Record<NodeType, {
   'ssh-server':      { label: 'SSH Server',        icon: 'bi-terminal',        badgeClass: 'bg-info text-dark',    color: '#1abc9c' },
   'ftp-server':      { label: 'FTP Server',        icon: 'bi-folder-symlink',  badgeClass: 'bg-secondary',         color: '#16a085' },
   'mail-server':     { label: 'Mail Server',       icon: 'bi-envelope',        badgeClass: 'bg-danger',            color: '#e91e63' },
-  'dhcp-server':     { label: 'DHCP Server',       icon: 'bi-diagram-3',       badgeClass: 'bg-secondary',         color: '#8e44ad' },
+  'dhcp-server':     { label: 'DHCP Server',       icon: 'bi-broadcast',       badgeClass: 'bg-secondary',         color: '#8e44ad' },
   'ntp-server':      { label: 'NTP Server',        icon: 'bi-clock',           badgeClass: 'bg-dark',              color: '#6c3483' },
   'database-server': { label: 'Database Server',   icon: 'bi-database',        badgeClass: 'bg-danger',            color: '#e67e22' },
   router:            { label: 'Router / Gateway',  icon: 'bi-router',          badgeClass: 'bg-warning text-dark', color: '#d4ac0d' },