Fix non-TTY interactive chat launch handling#8420
Closed
pandego wants to merge 1 commit into
Closed
Conversation
This was referenced Apr 25, 2026
Collaborator
This was referenced Apr 29, 2026
Author
|
closing this to reduce overlap. there are a few open PRs covering the same non-tty chat path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes chathermes chathandoff entirely when stdin is non-interactivehermes chat -q ...behavior for headless and piped use casesIssues
Root cause
Interactive chat startup had a TTY requirement in the codebase, but the
hermes chatpath was not enforcing it before handing off to the prompt_toolkit TUI. Separately, setup could still offer and exec into chat after configuration even when stdin was not a TTY. In headless environments that led to invalid interactive launches and downstream stdin attachment crashes.Fix
This keeps the change narrow and explicit:
--querywas providedValidation
uv run --python 3.11 --extra dev python -m pytest tests/hermes_cli/test_setup_noninteractive.py -n 0