fix(cli): PipeInput fallback when kqueue rejects stdin fd#9996
Closed
sougannkyou wants to merge 1 commit into
Closed
fix(cli): PipeInput fallback when kqueue rejects stdin fd#9996sougannkyou wants to merge 1 commit into
sougannkyou wants to merge 1 commit into
Conversation
…follow-up) On macOS with uv-managed cPython or inside IDE terminals (e.g. Kiro, VS Code), fstat(0) passes but the kqueue selector raises OSError [Errno 22] Invalid argument when prompt_toolkit tries to register fd 0 for async reads. The existing fstat() guard misses this case, causing an unhandled crash at startup. Fix: 1. Probe the actual selector with register(0, EVENT_READ) before creating the Application. If it fails, create a PipeInput and pass it as input= to prompt_toolkit. 2. A stdin feeder daemon thread reads from real sys.stdin and forwards lines into the pipe, so keystrokes still reach the TUI. 3. Add 'Invalid argument' to the existing OSError catch as a last-resort safety net. 4. Clean up the PipeInput context manager in the finally block.
This was referenced May 1, 2026
Contributor
|
Closing — superseded by #26077 (merged as commit d3d5916), which preventively probes kqueue at startup and falls back to SelectSelector when fd 0 cannot be registered. The widened except-clause matching EINVAL / EBADF / 'Invalid argument' — which most PRs in this cluster including yours added — is also included. Thanks for the fix; closing as duplicate of the merged work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS with uv-managed cPython or inside IDE terminals (Kiro, VS Code),
fstat(0)passes but the kqueue selector raisesOSError [Errno 22] Invalid argumentwhen prompt_toolkit tries to register fd 0 for async reads. The existingfstat()guard misses this case, causing an unhandled crash at startup:Related: #6393
Root Cause
The current pre-flight check only calls
os.fstat(0)which verifies the file descriptor exists, but does not verify it can be registered with the kqueue/epoll selector that asyncio and prompt_toolkit rely on. In certain environments (uv-managed Python on macOS, IDE embedded terminals), fd 0 is valid but not watchable by kqueue.Fix
Application, testDefaultSelector().register(0, EVENT_READ). If it fails, activate the fallback path.PipeInputviacreate_pipe_input()and pass it asinput=to theApplication, so prompt_toolkit never touches fd 0 directly.sys.stdinline-by-line and forwards into the pipe viasend_text(), so keystrokes still reach the TUI."Invalid argument"to the existingOSErrorcatch block as defense-in-depth.PipeInputcontext manager in thefinallyblock.Testing