Skip to content

[chore] remove mentions of flashrl from the repo and point to vllm quantization support instead#1855

Merged
erictang000 merged 4 commits into
NovaSky-AI:mainfrom
erictang000:remove_flash_rl
Jul 2, 2026
Merged

[chore] remove mentions of flashrl from the repo and point to vllm quantization support instead#1855
erictang000 merged 4 commits into
NovaSky-AI:mainfrom
erictang000:remove_flash_rl

Conversation

@erictang000

Copy link
Copy Markdown
Collaborator

closes #1658

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the experimental and patched FlashRL integration in favor of native quantized rollouts (FP8) supported directly through vLLM, utilizing Truncated Importance Sampling (TIS) for off-policy correction. This includes deleting FlashRL-specific documentation, examples, environment files, and code paths, while updating the documentation and codebase to reflect the native FP8 rollout workflow. A review comment correctly points out a syntax issue in a bash code block within the new documentation where comments break a backslash-continued multiline command.

Comment thread docs/content/docs/examples/quantized_rollouts.mdx
@SumanthRH

Copy link
Copy Markdown
Member

@erictang000 flashrl cleanup is being done as a part of #1835

@SumanthRH SumanthRH left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this PR just about a new "Training with Quantized Rollouts" doc?

@erictang000 erictang000 merged commit 506e65e into NovaSky-AI:main Jul 2, 2026
2 of 3 checks passed
@erictang000 erictang000 deleted the remove_flash_rl branch July 2, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cleanup] remove flashrl mentions from the repo

2 participants