fix(typescript): overload batch for either array or spread args#1964
Open
grddavies wants to merge 1 commit into
Open
fix(typescript): overload batch for either array or spread args#1964grddavies wants to merge 1 commit into
grddavies wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typescript types for
Database.batchallows spreading an array that includes an array of operations, despite the fact that this causes a runtime error:This snippet shows how this can result in runtime errors:
After updating the type definitions we get a compiler error in
Transaction.commit:Type 'Model[]' is not assignable to type 'false | void | Model | null'. ts (2345)May be related to #1952