feat(rocm): Add Windows support to ROCm backend#8
Closed
antmikinka wants to merge 0 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
rocm-supportbranch with full Windows compatibility for the ROCm/HIP backend. The original ROCm backend was developed for Linux; this PR adapts it to work with ROCm 7.1 on Windows 11.Changes Made
CMake Build System
CMakeLists.txt: Added Windows ROCm installation paths (C:/Program Files/AMD/ROCm/7.1/bin) and environment variable hints (ROCM_PATH,ROCM_HOME) for HIP compiler discoverymlx/backend/rocm/CMakeLists.txt:if(NOT WIN32).objon Windows,.oon Linux)-fPICon Windows (not needed for DLLs)-parallel-jobsclang-specific flag on Windows.libon Windows,.aon Linux)/OUT:for MSVC,rcsfor Unix)Source Code
allocator.cpp:#include <unistd.h>conditional on#ifndef _WIN32cross_platform_clzll()using_BitScanReverse64on MSVC and__builtin_clzllelsewherejit_module.cpp:_dup/_dup2/_open("nul"))ProgramFilesenv var and multiple version fallbacksTest Infrastructure
rocm_skip.py: Added skip entries for Metal-specific kernel tests (test_export_import_custom_kernel,test_custom_kernel_caching)main(31 commits) including critical Windows JIT compiler support (5d1c0e4c)Commits
16c411f8— Merge origin/main into rocm-support36f37be3— feat(rocm): Add Windows support to CMake build files3da1e3f2— feat(rocm): Add Windows support to ROCm backend source files3239866e— fix(rocm): Address quality review findings for Windows build2adb9d93— fix(rocm): Add ROCm skip entries for Metal-specific kernel testsEnvironment
C:\Program Files\AMD\ROCm\7.1\Notes
rocm-supportbranch, notmainrocm_skip.py(FFT, LAPACK, complex types, Metal-specific tests)