NuGet.Protocol nullability - Phase 1 (#7267)

nkolev92 · web-flow · commit bfeb9ffee240 · 2026-04-13T17:00:18.000-07:00
Phase 1: Constants, interfaces, exceptions, events, validated models
Phase 2: JSON models, search types, converters
diff --git a/src/NuGet.Clients/NuGet.VisualStudio.Internal.Contracts/ContextInfos/AlternatePackageMetadataContextInfo.cs b/src/NuGet.Clients/NuGet.VisualStudio.Internal.Contracts/ContextInfos/AlternatePackageMetadataContextInfo.cs
@@ -22,7 +22,7 @@ public static AlternatePackageMetadataContextInfo Create(AlternatePackageMetadat
         {
             Assumes.NotNull(alternatePackageMetadata);
 
-            return new AlternatePackageMetadataContextInfo(alternatePackageMetadata.PackageId, alternatePackageMetadata.Range);
+            return new AlternatePackageMetadataContextInfo(alternatePackageMetadata.PackageId!, alternatePackageMetadata.Range!);
         }
     }
 }
diff --git a/src/NuGet.Clients/NuGet.VisualStudio.Internal.Contracts/Formatters/SearchFilterFormatter.cs b/src/NuGet.Clients/NuGet.VisualStudio.Internal.Contracts/Formatters/SearchFilterFormatter.cs
@@ -63,9 +63,9 @@ private SearchFilterFormatter()
 
             return new SearchFilter(includePrerelease, filterType)
             {
-                SupportedFrameworks = supportedFrameworks,
+                SupportedFrameworks = supportedFrameworks ?? [],
                 OrderBy = searchOrderBy,
-                PackageTypes = packageTypes,
+                PackageTypes = packageTypes ?? [],
                 IncludeDelisted = includeDelisted,
             };
         }
diff --git a/src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/PackageSearch/PackageSearchResultTableRenderer.cs b/src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/PackageSearch/PackageSearchResultTableRenderer.cs
@@ -114,7 +114,7 @@ private static async void PopulateTableWithResultsAsync(IEnumerable<IPackageSear
 
                     if (packageDeprecationMetadata is not null)
                     {
-                        deprecation = packageDeprecationMetadata.Message;
+                        deprecation = packageDeprecationMetadata.Message ?? "N/A";
                     }
 
                     table.AddRow(
diff --git a/src/NuGet.Core/NuGet.Protocol/Converters/SafeBoolConverter.cs b/src/NuGet.Core/NuGet.Protocol/Converters/SafeBoolConverter.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using Newtonsoft.Json;
 
@@ -14,7 +12,7 @@ public class SafeBoolConverter : JsonConverter
         public override bool CanRead { get { return true; } }
         public override bool CanWrite { get { return false; } }
 
-        public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
+        public override object ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)
         {
             switch (reader.TokenType)
             {
@@ -24,19 +22,19 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
                     return serializer.Deserialize<bool>(reader);
                 case JsonToken.String:
                     bool flag;
-                    if (Boolean.TryParse(reader.Value.ToString().Trim(), out flag))
+                    if (Boolean.TryParse(reader.Value?.ToString()?.Trim(), out flag))
                     {
                         return flag;
                     }
                     return false;
                 case JsonToken.Integer:
-                    return ((long)reader.Value) == 1;
+                    return ((long)reader.Value!) == 1;
                 default:
                     reader.Skip();
                     return false;
             }
         }
-        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
+        public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)
         {
             throw new NotImplementedException();
         }
diff --git a/src/NuGet.Core/NuGet.Protocol/Converters/SafeUriConverter.cs b/src/NuGet.Core/NuGet.Protocol/Converters/SafeUriConverter.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using Newtonsoft.Json;
 
@@ -14,15 +12,14 @@ public class SafeUriConverter : JsonConverter
         public override bool CanRead { get { return true; } }
         public override bool CanWrite { get { return false; } }
 
-        public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
+        public override object? ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)
         {
             switch (reader.TokenType)
             {
                 case JsonToken.Null:
                     return null;
                 case JsonToken.String:
-                    Uri uri;
-                    if (Uri.TryCreate(reader.Value.ToString().Trim(), UriKind.Absolute, out uri))
+                    if (Uri.TryCreate(reader.Value?.ToString()?.Trim(), UriKind.Absolute, out Uri? uri))
                     {
                         return uri;
                     }
@@ -32,7 +29,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
                     return null;
             }
         }
-        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
+        public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)
         {
             throw new NotImplementedException();
         }
diff --git a/src/NuGet.Core/NuGet.Protocol/Converters/VersionRangeConverter.cs b/src/NuGet.Core/NuGet.Protocol/Converters/VersionRangeConverter.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using Newtonsoft.Json;
 using NuGet.Versioning;
@@ -29,10 +27,10 @@ public class VersionRangeConverter : JsonConverter
         /// <param name="existingValue">The existing value of the object.</param>
         /// <param name="serializer">A serializer.</param>
         /// <returns>A <see cref="VersionRange" /> object.</returns>
-        public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
+        public override object? ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)
         {
-            string value = serializer.Deserialize<string>(reader);
-            return !string.IsNullOrEmpty(value) ? VersionRange.Parse(value) : null;
+            string? value = serializer.Deserialize<string>(reader);
+            return !string.IsNullOrEmpty(value) ? VersionRange.Parse(value!) : null;
         }
 
         /// <summary>
@@ -41,9 +39,14 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
         /// <param name="writer">A JSON writer.</param>
         /// <param name="value">A value to serialize.</param>
         /// <param name="serializer">A serializer.</param>
-        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
+        public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)
         {
-            var versionRange = VersionRange.Parse(value.ToString());
+            if (value is null)
+            {
+                throw new ArgumentNullException(nameof(value));
+            }
+
+            var versionRange = VersionRange.Parse(value.ToString()!);
             serializer.Serialize(writer, versionRange.ToString());
         }
     }
diff --git a/src/NuGet.Core/NuGet.Protocol/Events/ProtocolDiagnosticNupkgCopiedEvent.cs b/src/NuGet.Core/NuGet.Protocol/Events/ProtocolDiagnosticNupkgCopiedEvent.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 namespace NuGet.Protocol.Events
 {
     public sealed class ProtocolDiagnosticNupkgCopiedEvent
diff --git a/src/NuGet.Core/NuGet.Protocol/Events/ProtocolDiagnosticResourceEvent.cs b/src/NuGet.Core/NuGet.Protocol/Events/ProtocolDiagnosticResourceEvent.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 
 namespace NuGet.Protocol.Events
diff --git a/src/NuGet.Core/NuGet.Protocol/Events/ProtocolDiagnosticServiceIndexEntryEvent.cs b/src/NuGet.Core/NuGet.Protocol/Events/ProtocolDiagnosticServiceIndexEntryEvent.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 namespace NuGet.Protocol.Events
 {
     /// <summary>
diff --git a/src/NuGet.Core/NuGet.Protocol/Exceptions/FatalProtocolException.cs b/src/NuGet.Core/NuGet.Protocol/Exceptions/FatalProtocolException.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.Runtime.Serialization;
 
diff --git a/src/NuGet.Core/NuGet.Protocol/Exceptions/InvalidCacheProtocolException.cs b/src/NuGet.Core/NuGet.Protocol/Exceptions/InvalidCacheProtocolException.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.Runtime.Serialization;
 using NuGet.Protocol.Core.Types;
diff --git a/src/NuGet.Core/NuGet.Protocol/Exceptions/NuGetProtocolException.cs b/src/NuGet.Core/NuGet.Protocol/Exceptions/NuGetProtocolException.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.Runtime.Serialization;
 
diff --git a/src/NuGet.Core/NuGet.Protocol/Exceptions/PackageNotFoundProtocolException.cs b/src/NuGet.Core/NuGet.Protocol/Exceptions/PackageNotFoundProtocolException.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.Globalization;
 using NuGet.Packaging.Core;
diff --git a/src/NuGet.Core/NuGet.Protocol/Exceptions/RetriableProtocolException.cs b/src/NuGet.Core/NuGet.Protocol/Exceptions/RetriableProtocolException.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.Runtime.Serialization;
 
diff --git a/src/NuGet.Core/NuGet.Protocol/FindPackageByIdDependencyInfo.cs b/src/NuGet.Core/NuGet.Protocol/FindPackageByIdDependencyInfo.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;
diff --git a/src/NuGet.Core/NuGet.Protocol/ILegacyFeedCapabilityResource.cs b/src/NuGet.Core/NuGet.Protocol/ILegacyFeedCapabilityResource.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System.Threading;
 using System.Threading.Tasks;
 using NuGet.Common;
diff --git a/src/NuGet.Core/NuGet.Protocol/Model/AlternatePackageMetadata.cs b/src/NuGet.Core/NuGet.Protocol/Model/AlternatePackageMetadata.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using Newtonsoft.Json;
 using NuGet.Versioning;
 
@@ -11,9 +9,9 @@ namespace NuGet.Protocol
     public class AlternatePackageMetadata
     {
         [JsonProperty(PropertyName = JsonProperties.PackageId)]
-        public string PackageId { get; internal set; }
+        public string? PackageId { get; internal set; }
 
         [JsonProperty(PropertyName = JsonProperties.Range, ItemConverterType = typeof(VersionRangeConverter))]
-        public VersionRange Range { get; internal set; }
+        public VersionRange? Range { get; internal set; }
     }
 }
diff --git a/src/NuGet.Core/NuGet.Protocol/Model/PackageDeprecationMetadata.cs b/src/NuGet.Core/NuGet.Protocol/Model/PackageDeprecationMetadata.cs
@@ -1,8 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
+using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
 
@@ -11,12 +10,12 @@ namespace NuGet.Protocol
     public class PackageDeprecationMetadata
     {
         [JsonProperty(PropertyName = JsonProperties.DeprecationMessage)]
-        public string Message { get; internal set; }
+        public string? Message { get; internal set; }
 
         [JsonProperty(PropertyName = JsonProperties.DeprecationReasons)]
-        public IEnumerable<string> Reasons { get; internal set; }
+        public IEnumerable<string> Reasons { get; internal set; } = Array.Empty<string>();
 
         [JsonProperty(PropertyName = JsonProperties.AlternatePackage)]
-        public AlternatePackageMetadata AlternatePackage { get; internal set; }
+        public AlternatePackageMetadata? AlternatePackage { get; internal set; }
     }
 }
diff --git a/src/NuGet.Core/NuGet.Protocol/Model/RepositoryCertificateInfo.cs b/src/NuGet.Core/NuGet.Protocol/Model/RepositoryCertificateInfo.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using Newtonsoft.Json;
 using NuGet.Packaging.Core;
@@ -11,22 +9,22 @@ namespace NuGet.Protocol
 {
     public class RepositoryCertificateInfo : IRepositoryCertificateInfo
     {
-        [JsonProperty(PropertyName = JsonProperties.Fingerprints)]
-        public Fingerprints Fingerprints { get; private set; }
+        [JsonProperty(PropertyName = JsonProperties.Fingerprints, Required = Required.Always)]
+        public Fingerprints Fingerprints { get; private set; } = null!;
 
-        [JsonProperty(PropertyName = JsonProperties.Subject)]
-        public string Subject { get; private set; }
+        [JsonProperty(PropertyName = JsonProperties.Subject, Required = Required.Always)]
+        public string Subject { get; private set; } = null!;
 
-        [JsonProperty(PropertyName = JsonProperties.Issuer)]
-        public string Issuer { get; private set; }
+        [JsonProperty(PropertyName = JsonProperties.Issuer, Required = Required.Always)]
+        public string Issuer { get; private set; } = null!;
 
-        [JsonProperty(PropertyName = JsonProperties.NotBefore)]
+        [JsonProperty(PropertyName = JsonProperties.NotBefore, Required = Required.Always)]
         public DateTimeOffset NotBefore { get; private set; }
 
-        [JsonProperty(PropertyName = JsonProperties.NotAfter)]
+        [JsonProperty(PropertyName = JsonProperties.NotAfter, Required = Required.Always)]
         public DateTimeOffset NotAfter { get; private set; }
 
-        [JsonProperty(PropertyName = JsonProperties.ContentUrl)]
-        public string ContentUrl { get; private set; }
+        [JsonProperty(PropertyName = JsonProperties.ContentUrl, Required = Required.Always)]
+        public string ContentUrl { get; private set; } = null!;
     }
 }
diff --git a/src/NuGet.Core/NuGet.Protocol/Model/ServiceIndexEntry.cs b/src/NuGet.Core/NuGet.Protocol/Model/ServiceIndexEntry.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using NuGet.Versioning;
 
diff --git a/src/NuGet.Core/NuGet.Protocol/Model/VersionInfo.cs b/src/NuGet.Core/NuGet.Protocol/Model/VersionInfo.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using NuGet.Versioning;
 
 namespace NuGet.Protocol.Core.Types
@@ -14,7 +12,7 @@ public VersionInfo(NuGetVersion version)
         {
         }
 
-        public VersionInfo(NuGetVersion version, string downloadCount)
+        public VersionInfo(NuGetVersion version, string? downloadCount)
         {
             Version = version;
 
@@ -41,6 +39,6 @@ public VersionInfo(NuGetVersion version, long? downloadCount)
         /// here. For V3, the metadata property is null. Callers that receive this type need to be able to
         /// fetch this package metadata some other way if this property is null.
         /// </summary>
-        public IPackageSearchMetadata PackageSearchMetadata { get; set; }
+        public IPackageSearchMetadata? PackageSearchMetadata { get; set; }
     }
 }
diff --git a/src/NuGet.Core/NuGet.Protocol/NuGetResourceProviderPositions.cs b/src/NuGet.Core/NuGet.Protocol/NuGetResourceProviderPositions.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 namespace NuGet.Protocol.Core.Types
 {
     /// <summary>
diff --git a/src/NuGet.Core/NuGet.Protocol/NuGetTestMode.cs b/src/NuGet.Core/NuGet.Protocol/NuGetTestMode.cs
@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 
 namespace NuGet.Protocol.Core.Types
diff --git a/src/NuGet.Core/NuGet.Protocol/PackageProgressEventArgs.cs b/src/NuGet.Core/NuGet.Protocol/PackageProgressEventArgs.cs
diff --git a/src/NuGet.Core/NuGet.Protocol/ProtocolConstants.cs b/src/NuGet.Core/NuGet.Protocol/ProtocolConstants.cs
diff --git a/src/NuGet.Core/NuGet.Protocol/PublicAPI/net472/PublicAPI.Shipped.txt b/src/NuGet.Core/NuGet.Protocol/PublicAPI/net472/PublicAPI.Shipped.txt
diff --git a/src/NuGet.Core/NuGet.Protocol/PublicAPI/net8.0/PublicAPI.Shipped.txt b/src/NuGet.Core/NuGet.Protocol/PublicAPI/net8.0/PublicAPI.Shipped.txt
diff --git a/src/NuGet.Core/NuGet.Protocol/Resources/DownloadResource.cs b/src/NuGet.Core/NuGet.Protocol/Resources/DownloadResource.cs
diff --git a/src/NuGet.Core/NuGet.Protocol/SearchFilter.cs b/src/NuGet.Core/NuGet.Protocol/SearchFilter.cs
diff --git a/src/NuGet.Core/NuGet.Protocol/ServiceTypes.cs b/src/NuGet.Core/NuGet.Protocol/ServiceTypes.cs

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public static AlternatePackageMetadataContextInfo Create(AlternatePackageMetadat`
`22`	`22`	`{`
`23`	`23`	`Assumes.NotNull(alternatePackageMetadata);`
`24`	`24`
`25`		`- return new AlternatePackageMetadataContextInfo(alternatePackageMetadata.PackageId, alternatePackageMetadata.Range);`
	`25`	`+ return new AlternatePackageMetadataContextInfo(alternatePackageMetadata.PackageId!, alternatePackageMetadata.Range!);`
`26`	`26`	`}`
`27`	`27`	`}`
`28`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,9 +63,9 @@ private SearchFilterFormatter()`
`63`	`63`
`64`	`64`	`return new SearchFilter(includePrerelease, filterType)`
`65`	`65`	`{`
`66`		`- SupportedFrameworks = supportedFrameworks,`
	`66`	`+ SupportedFrameworks = supportedFrameworks ?? [],`
`67`	`67`	`OrderBy = searchOrderBy,`
`68`		`- PackageTypes = packageTypes,`
	`68`	`+ PackageTypes = packageTypes ?? [],`
`69`	`69`	`IncludeDelisted = includeDelisted,`
`70`	`70`	`};`
`71`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ private static async void PopulateTableWithResultsAsync(IEnumerable<IPackageSear`
`114`	`114`
`115`	`115`	`if (packageDeprecationMetadata is not null)`
`116`	`116`	`{`
`117`		`- deprecation = packageDeprecationMetadata.Message;`
	`117`	`+ deprecation = packageDeprecationMetadata.Message ?? "N/A";`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`table.AddRow(`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,6 @@`
`1`	`1`	`// Copyright (c) .NET Foundation. All rights reserved.`
`2`	`2`	`// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.`
`3`	`3`
`4`		`-#nullable disable`
`5`		`-`
`6`	`4`	`using System;`
`7`	`5`	`using Newtonsoft.Json;`
`8`	`6`
`@@ -14,7 +12,7 @@ public class SafeBoolConverter : JsonConverter`
`14`	`12`	`public override bool CanRead { get { return true; } }`
`15`	`13`	`public override bool CanWrite { get { return false; } }`
`16`	`14`
`17`		`- public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)`
	`15`	`+ public override object ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)`
`18`	`16`	`{`
`19`	`17`	`switch (reader.TokenType)`
`20`	`18`	`{`
`@@ -24,19 +22,19 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist`
`24`	`22`	`return serializer.Deserialize<bool>(reader);`
`25`	`23`	`case JsonToken.String:`
`26`	`24`	`bool flag;`
`27`		`- if (Boolean.TryParse(reader.Value.ToString().Trim(), out flag))`
	`25`	`+ if (Boolean.TryParse(reader.Value?.ToString()?.Trim(), out flag))`
`28`	`26`	`{`
`29`	`27`	`return flag;`
`30`	`28`	`}`
`31`	`29`	`return false;`
`32`	`30`	`case JsonToken.Integer:`
`33`		`- return ((long)reader.Value) == 1;`
	`31`	`+ return ((long)reader.Value!) == 1;`
`34`	`32`	`default:`
`35`	`33`	`reader.Skip();`
`36`	`34`	`return false;`
`37`	`35`	`}`
`38`	`36`	`}`
`39`		`- public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)`
	`37`	`+ public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)`
`40`	`38`	`{`
`41`	`39`	`throw new NotImplementedException();`
`42`	`40`	`}`