Initialize resource when GetInstalledVersions is called first#7245
Merged
Initialize resource when GetInstalledVersions is called first#7245
Conversation
jeffkl
previously approved these changes
Mar 31, 2026
martinrrm
previously approved these changes
Apr 1, 2026
jeffkl
approved these changes
Apr 13, 2026
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14837
Description
This could lead to some false negatives in some cases.
Note that in all non-lock file scenarios other methods would be called first in the restore codepaths, so it's fortuituously initialized.
In lock file scenarios with 1 package, that's not the case and that's what my test is/was.
NuGet/Home#14107 (comment)
This is not very likely to be a thing in practice, as it would effectively require a single package scenarios so that other calls to the source don't end up initializing things.
Note that I switched the throttle semaphore acquisition and the EnsureResource calls in a few places. Tests were failing without it.
If EnsureResource failed, we'd release the semaphore despite never acquiring it, leading to SemaphoreFullException.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.