Conversation
Nigusu-Allehu
changed the title
Nigusu-Allehu
changed the title
dotnet-policy-service
Bot
added
the
Status:No recent activity
Nigusu-Allehu
force-pushed
the
dev-nyenework-add-gate-tests
branch
from
35d7c8e to
0995a8f
Compare
dotnet-policy-service
Bot
removed
the
Status:No recent activity
| uiwindow.InstallPackageFromUI(TestPackageName, TestPackageVersionV1); | ||
|
|
||
| // Assert | ||
| CommonUtility.AssertPackageInPackagesConfig(VisualStudio, project, TestPackageName, TestPackageVersionV1, Logger); |
There was a problem hiding this comment.
These are all packages.config tests.
We need/want .NET core based tests, so it needs to be a netcore class library test.
| [TestMethod] | ||
| [Timeout(DefaultTimeout)] | ||
| [TestCategory("Gate")] | ||
| public async Task InstallTopLevelPackageFromUI() |
There was a problem hiding this comment.
How did you pick this one?
There's an overlap in the scenario in this method and the one from the regular apex tests.
There was a problem hiding this comment.
This one is Net core, and the other ones are packages config.
There was a problem hiding this comment.
So this test case is from the apex daily pipeline, which is not even something we see in our CI right now. It's supposed to be additional tests.
I'm assuming there's probably a net core version of this scenario in the regular apex tests.
There was a problem hiding this comment.
Maybe I missed it, but I didn't find any focused(simple install/restore) net core tests in the per commit tests. However there are PSM net core tests. Maybe we could make use of them. I will take a look.
There was a problem hiding this comment.
Wow, that's surprising.
We can keep this one then for simplicity. We can always move things around I guess.
Maybe we move that test into the regular pipeline since you've already determined it's stable?
|
|
||
| [TestMethod] | ||
| [Timeout(DefaultTimeout)] | ||
| [TestCategory("Gate")] |
There was a problem hiding this comment.
Similarly here, this tests the PM UI Top Level and Transitive Package differentiation.
I don't think that's something likely to be broken by partner teams, so I don't think this is a relevant test.
2 participants
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3725
Related: https://github.com/NuGet/Client.Engineering/issues/3543
Description
Previously we added a drop for that will be used by the gate tests: #7247. And the drop has a runsetting that specifies a test catagory "Gate". This PR adds more tests to that catagory.
Two gate tests
([TestCategory("Gate")])to NuGet.Tests.ApexInstallAndUpdatePackageFromUI_NetCoreProject_Succeeds: Verifies a package can be installed and updated to a newer versionVerifyDeletedAssetsFileIsBackByReloadingProject: Verifies that auto-restore regenerates project.assets.json whenit is deleted
Both tests are simplified single-template versions copied from NuGet.Tests.Apex.Daily.
Also removed
SimpleInstallFromIVsInstallerwhich was added just for testing the piepline.PR Checklist