Skip to content

Cache NUGET_DISABLE_PACKAGEID_VALIDATION env var read in PackageIdValidator.Validate to eliminate per-call allocations #7266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffkl merged 3 commits into from
Apr 14, 2026
Merged

Cache NUGET_DISABLE_PACKAGEID_VALIDATION env var read in PackageIdValidator.Validate to eliminate per-call allocations #7266

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fb9701
Cache NUGET_DISABLE_PACKAGEID_VALIDATION env var read in PackageIdVal…
nareshjo Apr 8, 2026
22ba9d3
Fix naming convention and reduce duplication
nareshjo Apr 8, 2026
977e18b
address PR feedback
nareshjo Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/NuGet.Core/NuGet.Protocol/Utility/PackageIdValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ namespace NuGet.Protocol
{
internal static class PackageIdValidator
{
private const string DisableValidationEnvVar = "NUGET_DISABLE_PACKAGEID_VALIDATION";

private static readonly Lazy<bool> IsValidationDisabled = new Lazy<bool>(() =>
IsPackageIdValidationDisabled(EnvironmentVariableWrapper.Instance));

/// <summary>
/// Validates the package ID content.
/// </summary>
Expand All @@ -21,20 +26,20 @@ internal static class PackageIdValidator
/// </exception>
internal static void Validate(string packageId, IEnvironmentVariableReader env = null)
{
if (env == null)
{
env = EnvironmentVariableWrapper.Instance;
}

string disableValidationEnvVarValue = env.GetEnvironmentVariable("NUGET_DISABLE_PACKAGEID_VALIDATION");
bool isDisabled = env == null
? IsValidationDisabled.Value
: IsPackageIdValidationDisabled(env);

if (!string.Equals(disableValidationEnvVarValue, "true", StringComparison.OrdinalIgnoreCase))
if (!isDisabled)
{
if (!Packaging.PackageIdValidator.IsValidPackageId(packageId))
{
throw new InvalidPackageIdException(string.Format(CultureInfo.CurrentCulture, Strings.Error_Invalid_package_id, packageId));
}
}
}

private static bool IsPackageIdValidationDisabled(IEnvironmentVariableReader env) =>
string.Equals(env.GetEnvironmentVariable(DisableValidationEnvVar), bool.TrueString, StringComparison.OrdinalIgnoreCase);
}
}
Loading