clean up conditional compilation for now-removed TFMs#7415
Conversation
dotnet-policy-service
Bot
added
the
Community
nkolev92
left a comment
nkolev92
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
It'd be great to follow the PR template, because it actually guides you to the information we need to more effectively review the PR.
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| #if !NETSTANDARD2_1 && !NETCOREAPP3_1_OR_GREATER && !NET5_0_OR_GREATER |
There was a problem hiding this comment.
We still have 1 project that targets NS2.0 (NuGet.VisualStudio.Contracts), so in case we want to enable nullability there we should keep the NS2.0 support in this file.
|
|
||
| private static void CopyTo(Stream inputStream, Stream outputStream) | ||
| { | ||
| // .NET Framework allocates an unavoidable byte[] when using |
There was a problem hiding this comment.
This seems to suggest it shouldn't be removed.
This seems like a significant decision, so we either need this reverted, or explained why it's unnecessary.
Either way I would've loved to see this called out in the PR description to help the reviewer.
nkolev92
added
the
Engineering
dotnet-policy-service
Bot
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 30 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
3 participants
Since NuGet now only builds for net472 and net8.0, we can remove all the .NET Standard and previous workarounds.