Make SearchFilter.PackageType singular rather than plural#7469
Merged
Conversation
nkolev92
approved these changes
Jun 10, 2026
jebriede
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14941
Fixes: NuGet/Home#14936
also follow up of #7395
Description
We had a community contribution recently: #7395
In the PR, I made two comments about things that I think should be improved, so I implemented it myself, in addition to some additional changes:
IEnumerable<string> PackageTypesproperty, and add a newstring PackageTypeproperty toSearchFilter. See the linked issue for more information.SupportsPackageTypeFilteringproperty toPackageSearchResource, so callers can check whether the feed supports package type filtering before callingSearchAsync, givenSearchAsyncwill throw ifPackageTypeis not null or empty on feeds that don't support it.PR Checklist
Added testsAlmost entirely a refactoring, not adding new functionality or fixing bugs.Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.N/A