Skip to content

fix(appimage): drop injected --no-sandbox in the Linux launcher wrapper #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sproctor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(appimage): drop injected --no-sandbox in the Linux launcher wrapper #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...thub/kdroidfilter/nucleus/desktop/application/tasks/AbstractElectronBuilderPackageTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,6 +1112,15 @@ abstract class AbstractElectronBuilderPackageTask
esac
done
DIR="$(cd "$(dirname "$SCRIPT")" && pwd)"
# electron-builder's AppImage AppRun injects --no-sandbox when unprivileged user
# namespaces are unavailable (the Ubuntu 24.04+ default), on the assumption the
# binary is Chromium/Electron. This is a JVM/native app with no such sandbox, and
# its launcher may abort on the unknown option, so drop the flag before delegating.
for arg in "$@"; do
shift
[ "$arg" = "--no-sandbox" ] && continue
set -- "$@" "$arg"
done
exec "$DIR/$$relativePath" "$@"
""".trimIndent() + "\n"

Expand Down
Loading