Add integration test for queue helper currying with fn helper#68
Draft
Copilot wants to merge 3 commits into
Draft
Add integration test for queue helper currying with fn helper#68Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/NullVoxPopuli/ember-composable-helpers/sessions/5f2e4aa9-9d35-4931-8365-4805e26d52ee Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
NullVoxPopuli
March 27, 2026 16:48
View session
| this.set('value', 0); | ||
| await render(hbs` | ||
| <p>{{this.value}}</p> | ||
| {{#let (queue this.doAThing this.process this.undoAThing) as |queuedActions|}} |
Owner
There was a problem hiding this comment.
@copilot there is no fn here. please use fn - https://guides.emberjs.com/v5.5.0/upgrading/current-edition/action-on-and-fn/
Author
There was a problem hiding this comment.
Fixed in 3573aa7. Now uses fn to curry arguments directly into functions passed to queue: (queue this.doAThing (fn this.process 3) this.undoAThing) with {{on "click"}}. All 8 queue tests pass.
… result Agent-Logs-Url: https://github.com/NullVoxPopuli/ember-composable-helpers/sessions/c3a16e42-fc02-4126-8f50-9d8cf8c22440 Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/NullVoxPopuli/ember-composable-helpers/sessions/ae4ebe86-c55f-44a6-8f1c-f65f0c7b3838 Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fnhelperfnto curry arguments into functions passed toqueuepackage-lock.json(project uses pnpm)⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.