Use julia-downgrade-compat@2#227
Conversation
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Pull Request Test Coverage Report for Build 22516540989Details
💛 - Coveralls |
|
Hm, the Downgrade job seems to just use the same versions as the normal job (see https://github.com/NumericalMathematics/DispersiveShallowWater.jl/actions/runs/16541187956/job/46782631560?pr=227#step:8:57 and https://github.com/NumericalMathematics/DispersiveShallowWater.jl/actions/runs/16541187950/job/46782631572?pr=227#step:7:52) meaning it doesn't really test the compat bounds. Same also happens in SciML/SciMLBase.jl#1075. I think the new version is not quite ready yet. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
I already prepared this PR to what would need to be done once StefanKarpinski/Resolver.jl#15 is resolved. |
|
With StefanKarpinski/Resolver.jl#19 now merged, the downgrade job using julia-downgrade-compat@2 is now successful. Bumping RecursiveArrayTools.jl and StaticArrays.jl is fine I think because the previous oldest possible versions were not compatible/had bugs and were not used by the previous downgrade action version (I think because for packages with major version >0 it was less strict than the current version of the downgrade action, see also https://github.com/julia-actions/julia-downgrade-compat/blob/2f6400ecbd1a7229a6630aea5d062ac82169a396/README.md#L55). Regarding the bump of Plots.jl I wrote my analysis is in julia-actions/julia-downgrade-compat#37 (comment). I think, there is still potential for improvements in Resolver.jl, but at least the new downgrade action version seems mostly usable now for us. I'll check in a few other repos to see if there are any other issues. If not, we could try to move to the v2 of the action. What do you think, @ranocha (and thanks again for your fix in Resolver.jl)? |
ranocha
left a comment
There was a problem hiding this comment.
Sounds like a good plan. Thanks!
|
This should finally be ready. |
ranocha
left a comment
There was a problem hiding this comment.
Thanks for all the work you put into fixing and updating downgrade actions!
With the new julia-downgrade-compat v2, the action switched to use Resolver.jl to find minimal compatible versions. If everything works as intended, this makes it MUCH simpler to work with and debug the downgrade action because in case of incompatible lower bounds, you don't need to resolve the incompatibilities manually by finding out a set of working minimal bounds. This should now be done by Resolver.jl.