Skip to content

CompatHelper: bump compat for RecursiveArrayTools to 4, (keep existing compat)#291

Open
github-actions[bot] wants to merge 13 commits intomainfrom
compathelper/new_version/2026-04-02-00-49-09-846-02114810851
Open

CompatHelper: bump compat for RecursiveArrayTools to 4, (keep existing compat)#291
github-actions[bot] wants to merge 13 commits intomainfrom
compathelper/new_version/2026-04-02-00-49-09-846-02114810851

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Apr 2, 2026

This pull request changes the compat entry for the RecursiveArrayTools package from 3.27.2 to 3.27.2, 4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Closes #292, closes #294, closes #295, closes #296, closes #297, closes #298, closes #299, closes #300, closes #301, closes #302, closes #303.

@JoshuaLampert JoshuaLampert force-pushed the compathelper/new_version/2026-04-02-00-49-09-846-02114810851 branch from 5fff896 to 01712ff Compare April 2, 2026 00:49
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Apr 2, 2026

Benchmark Results (Julia v1.10)

Time benchmarks
main fd21345... main / fd21345...
bbm_1d/bbm_1d_basic.jl - rhs!: 14.1 ± 0.39 μs 14 ± 0.32 μs 1 ± 0.036
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.53 ± 0.011 ms 0.529 ± 0.012 ms 1 ± 0.031
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0818 ± 0.0022 ms 0.0823 ± 0.0025 ms 0.994 ± 0.041
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0341 ± 0.00073 ms 0.0342 ± 0.00061 ms 0.999 ± 0.028
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.6 ± 1 μs 27.9 ± 0.57 μs 0.99 ± 0.041
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0493 ± 0.0019 ms 0.0498 ± 0.00079 ms 0.992 ± 0.04
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.17 ± 0.04 μs 4.12 ± 0.03 μs 1.01 ± 0.012
kdv_1d/kdv_1d_basic.jl - rhs!: 1.38 ± 0.021 μs 1.6 ± 0.02 μs 0.863 ± 0.017
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.35 ± 0.011 μs 1.44 ± 0.011 μs 0.938 ± 0.01
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.208 ± 0.018 ms 0.214 ± 0.013 ms 0.972 ± 0.1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.149 ± 0.0069 ms 0.154 ± 0.0079 ms 0.965 ± 0.066
time_to_load 2.42 ± 0.016 s 2.27 ± 0.017 s 1.07 ± 0.011
Memory benchmarks
main fd21345... main / fd21345...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/callbacks_step/summary.jl 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 2, 2026

Coverage Report for CI Build 25158120313

Coverage remained the same at 98.483%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 uncovered change across 1 file (1 of 2 lines covered, 50.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/callbacks_step/summary.jl 1 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2571
Covered Lines: 2532
Line Coverage: 98.48%
Coverage Strength: 8183355.7 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JoshuaLampert
JoshuaLampert previously approved these changes Apr 26, 2026
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The warnings like

┌ Warning: Runtime invalidation was disabled, but the CPU info is out-of-date.
│ Will continue with incorrect CPU name (from build time).
└ @ HostCPUFeatures ~/.julia/packages/HostCPUFeatures/ZTXz4/src/cpu_info.jl:71

were also already present in the last CI run on main: https://github.com/NumericalMathematics/DispersiveShallowWater.jl/actions/runs/24400348279/job/71268950948#step:7:460.

@JoshuaLampert JoshuaLampert requested a review from ranocha April 26, 2026 22:13
JoshuaLampert
JoshuaLampert previously approved these changes Apr 27, 2026
@JoshuaLampert
Copy link
Copy Markdown
Member

@ranocha, you already use dependabot for the julia compat updates in SummationByPartsOperators.jl, don't you? It supports grouping compat PRs right? This makes these kind of compat updates, which depend on each other, easier to handle. Did you make good experiences with dependabot for julia compat PR? Do you think it's time to switch from CompatHelper to dependabot (dependabot for julia is out of beta state already).

Comment thread test/Project.toml Outdated
JoshuaLampert
JoshuaLampert previously approved these changes Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants