Skip to content

CompatHelper: bump compat for Roots to 3, (keep existing compat)#293

Merged
JoshuaLampert merged 2 commits intomainfrom
compathelper/new_version/2026-04-14-00-57-46-505-01134200830
Apr 14, 2026
Merged

CompatHelper: bump compat for Roots to 3, (keep existing compat)#293
JoshuaLampert merged 2 commits intomainfrom
compathelper/new_version/2026-04-14-00-57-46-505-01134200830

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This pull request changes the compat entry for the Roots package from 2.0.17 to 2.0.17, 3.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@JoshuaLampert JoshuaLampert force-pushed the compathelper/new_version/2026-04-14-00-57-46-505-01134200830 branch from eae2e01 to d36a2bf Compare April 14, 2026 00:57
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Apr 14, 2026

Benchmark Results (Julia v1.10)

Time benchmarks
main 8cc5882... main / 8cc5882...
bbm_1d/bbm_1d_basic.jl - rhs!: 13.9 ± 0.32 μs 13.9 ± 0.52 μs 0.997 ± 0.044
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.536 ± 0.011 ms 0.527 ± 0.32 ms 1.02 ± 0.61
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0809 ± 0.00028 ms 0.0818 ± 0.00028 ms 0.989 ± 0.0048
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0349 ± 0.00069 ms 0.0347 ± 0.0027 ms 1.01 ± 0.08
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.7 ± 1.1 μs 27.5 ± 1.4 μs 1.01 ± 0.064
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0488 ± 0.0017 ms 0.0489 ± 0.0028 ms 0.999 ± 0.066
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.25 ± 0.03 μs 4.2 ± 0.03 μs 1.01 ± 0.01
kdv_1d/kdv_1d_basic.jl - rhs!: 1.39 ± 0.02 μs 1.4 ± 0.029 μs 0.993 ± 0.025
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.39 ± 0.02 μs 1.49 ± 0.02 μs 0.933 ± 0.018
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.2 ± 0.01 ms 0.197 ± 0.0098 ms 1.01 ± 0.072
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.148 ± 0.0039 ms 0.144 ± 0.0043 ms 1.02 ± 0.041
time_to_load 2.36 ± 0.027 s 2.36 ± 0.019 s 1 ± 0.014
Memory benchmarks
main 8cc5882... main / 8cc5882...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 14, 2026

Coverage Report for CI Build 24386781999

Coverage remained the same at 98.483%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2571
Covered Lines: 2532
Line Coverage: 98.48%
Coverage Strength: 16372555.68 hits per line

💛 - Coveralls

Comment thread Project.toml
Comment thread Project.toml Outdated
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the registry still does not know Roots.jl v3 and uses the old one. I also tried locally to install Roots.jl v3 in a temporary environment and it is not installable. The registry looks fine though https://github.com/JuliaRegistries/General/blob/d5254bf9b19e43e6c5d5d7faf3e9d20aeb408f0d/R/Roots/Versions.toml#L271-L272. I'll retry later again.

Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roots.jl v3 is now used in CI.

@JoshuaLampert JoshuaLampert merged commit 88fef0e into main Apr 14, 2026
19 checks passed
@JoshuaLampert JoshuaLampert deleted the compathelper/new_version/2026-04-14-00-57-46-505-01134200830 branch April 14, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants