CompatHelper: bump compat for Roots to 3, (keep existing compat)#293
Merged
JoshuaLampert merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
eae2e01 to
d36a2bf
Compare
Contributor
Author
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Coverage Report for CI Build 24386781999Coverage remained the same at 98.483%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
JoshuaLampert
requested changes
Apr 14, 2026
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
JoshuaLampert
requested changes
Apr 14, 2026
Member
JoshuaLampert
left a comment
There was a problem hiding this comment.
For some reason the registry still does not know Roots.jl v3 and uses the old one. I also tried locally to install Roots.jl v3 in a temporary environment and it is not installable. The registry looks fine though https://github.com/JuliaRegistries/General/blob/d5254bf9b19e43e6c5d5d7faf3e9d20aeb408f0d/R/Roots/Versions.toml#L271-L272. I'll retry later again.
JoshuaLampert
approved these changes
Apr 14, 2026
Member
JoshuaLampert
left a comment
There was a problem hiding this comment.
Roots.jl v3 is now used in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Rootspackage from2.0.17to2.0.17, 3.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.