Skip to content

Fix coverallsapp GitHub action on macOS#308

Merged
JoshuaLampert merged 1 commit into
mainfrom
fix-coveralls-macos
Jul 1, 2026
Merged

Fix coverallsapp GitHub action on macOS#308
JoshuaLampert merged 1 commit into
mainfrom
fix-coveralls-macos

Conversation

@JoshuaLampert

@JoshuaLampert JoshuaLampert commented Jul 1, 2026

Copy link
Copy Markdown
Member

CI on MacOS is currently failing due to the coveralls GitHub action, see coverallsapp/github-action#264. This applies the workaround suggested in that issue. Once coverallsapp/github-action#265 is merged and released, this workaround can be reverted again.

@ranocha ranocha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1.10)

Time benchmarks
main de352ee... main / de352ee...
bbm_1d/bbm_1d_basic.jl - rhs!: 13.7 ± 0.26 μs 14.2 ± 0.41 μs 0.966 ± 0.033
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.527 ± 0.3 ms 0.526 ± 0.32 ms 1 ± 0.84
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0798 ± 0.00026 ms 0.0796 ± 0.00023 ms 1 ± 0.0044
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0342 ± 0.00051 ms 0.034 ± 0.00044 ms 1.01 ± 0.02
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.2 ± 0.46 μs 27.3 ± 0.44 μs 0.996 ± 0.023
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.049 ± 0.00053 ms 0.049 ± 0.00051 ms 1 ± 0.015
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.22 ± 0.04 μs 4.15 ± 0.03 μs 1.02 ± 0.012
kdv_1d/kdv_1d_basic.jl - rhs!: 1.39 ± 0.011 μs 1.34 ± 0.01 μs 1.04 ± 0.011
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.42 ± 0.011 μs 1.43 ± 0.019 μs 0.994 ± 0.015
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.202 ± 0.0083 ms 0.199 ± 0.0087 ms 1.02 ± 0.061
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.151 ± 0.0051 ms 0.15 ± 0.0052 ms 1.01 ± 0.049
time_to_load 2.25 ± 0.013 s 2.19 ± 0.0057 s 1.03 ± 0.0064
Memory benchmarks
main de352ee... main / de352ee...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 28524899088

Warning

No base build found for commit 87623a6 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 98.483%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 2571
Covered Lines: 2532
Line Coverage: 98.48%
Coverage Strength: 8183355.7 hits per line

💛 - Coveralls

@JoshuaLampert
JoshuaLampert merged commit 3ff28e5 into main Jul 1, 2026
11 checks passed
@JoshuaLampert
JoshuaLampert deleted the fix-coveralls-macos branch July 1, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants