Fully skip Aqua in downstream testing#148
Merged
Merged
Conversation
Aqua.jl just doesn't generally do well with downstream tests. So instead of disabling one test, it should just disable them all. This will fix https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/13932593014/job/38997101429#step:5:1605
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 7 7
Lines 1637 1637
=======================================
Hits 1606 1606
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Downgrade fails because of an upstream issue, see SciML/OrdinaryDiffEq.jl#2639 |
Member
|
Downgrade tests also failed in #149 already. |
ranocha
approved these changes
Mar 24, 2025
ranocha
left a comment
ranocha
left a comment
Member
There was a problem hiding this comment.
Hmm... Let's merge this to make OrdinaryDiffEq.jl downstream tests pass and debug the issue afterward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aqua.jl just doesn't generally do well with downstream tests. So instead of disabling one test, it should just disable them all. This will fix https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/13932593014/job/38997101429#step:5:1605