Pass an FSharpProjectOptions down into the lint machinery when available

Rather than reading it from FSharpCheckProjectResults on every use,
which appears to have a substantional performance cost.

The project options is stored as a Lazy because it's expensive to
calculate and only used by a few rules, so the work can be avoided
altogether if those rules aren't being run.

refs fsprojects#770

Author: Numpsy

src/FSharpLint.Core/Application/Lint.fs

@@ -125,6 +125,7 @@ module Lint =
             GlobalConfig: Rules.GlobalRuleConfig
             TypeCheckResults: FSharpCheckFileResults option
             ProjectCheckResults: FSharpCheckProjectResults option
+            ProjectOptions: Lazy<FSharpProjectOptions option>
             FilePath: string
             FileContent: string
             Lines: string[]
@@ -149,6 +150,7 @@ module Lint =
                     Lines = config.Lines
                     CheckInfo = config.TypeCheckResults
                     ProjectCheckInfo = config.ProjectCheckResults
+                    ProjectOptions = config.ProjectOptions
                     GlobalConfig = config.GlobalConfig
                 }
             // Build state for rules with context.
@@ -263,6 +265,10 @@ module Lint =
                         GlobalConfig = enabledRules.GlobalConfig
                         TypeCheckResults = fileInfo.TypeCheckResults
                         ProjectCheckResults = fileInfo.ProjectCheckResults
+                        ProjectOptions = lazy( 
+                            fileInfo.ProjectCheckResults
+                            |> Option.map _.ProjectContext.ProjectOptions
+                        )
                         FilePath = fileInfo.File
                         FileContent = fileInfo.Text
                         Lines = lines

src/FSharpLint.Core/Application/Lint.fsi

@@ -129,6 +129,7 @@ module Lint =
             GlobalConfig: Rules.GlobalRuleConfig
             TypeCheckResults: FSharpCheckFileResults option
             ProjectCheckResults: FSharpCheckProjectResults option
+            ProjectOptions: Lazy<FSharpProjectOptions option>
             FilePath: string
             FileContent: string
             Lines: string[]

src/FSharpLint.Core/Framework/Rules.fs

@@ -31,6 +31,7 @@ type AstNodeRuleParams =
       Lines:string []
       CheckInfo:FSharpCheckFileResults option
       ProjectCheckInfo:FSharpCheckProjectResults option
+      ProjectOptions: Lazy<FSharpProjectOptions option>
       GlobalConfig:GlobalRuleConfig }
 
 type LineRuleParams =

src/FSharpLint.Core/Rules/Conventions/Naming/AsynchronousFunctionNames.fs

@@ -32,8 +32,8 @@ let runner (config: Config) (args: AstNodeRuleParams) =
         | _ -> config.Mode = AllAPIs
 
     let likelyhoodOfBeingInLibrary =
-        match args.ProjectCheckInfo with
-        | Some projectInfo -> howLikelyProjectIsLibrary projectInfo.ProjectContext.ProjectOptions.ProjectFileName
+        match args.ProjectOptions.Value with
+        | Some projectOptions -> howLikelyProjectIsLibrary projectOptions.ProjectFileName
         | None -> Unlikely
 
     if config.Mode = OnlyPublicAPIsInLibraries && likelyhoodOfBeingInLibrary <> Likely then

src/FSharpLint.Core/Rules/Conventions/Naming/SimpleAsyncComplementaryHelpers.fs

@@ -205,8 +205,8 @@ let runner (config: Config) (args: AstNodeRuleParams) =
         Array.append (checkFuncs asyncFuncs taskFuncs) (checkFuncs taskFuncs asyncFuncs)
 
     let likelyhoodOfBeingInLibrary =
-        match args.ProjectCheckInfo with
-        | Some projectInfo -> howLikelyProjectIsLibrary projectInfo.ProjectContext.ProjectOptions.ProjectFileName
+        match args.ProjectOptions.Value with
+        | Some projectOptions -> howLikelyProjectIsLibrary projectOptions.ProjectFileName
         | None -> Unlikely
 
     if config.Mode = OnlyPublicAPIsInLibraries && likelyhoodOfBeingInLibrary <> Likely then

src/FSharpLint.Core/Rules/Smells/NoAsyncRunSynchronouslyInLibrary.fs

@@ -95,9 +95,9 @@ let checkIfInLibrary (args: AstNodeRuleParams) (range: range) : array<WarningDet
     let ruleNotApplicable =
         isInObsoleteMethodOrFunction (args.GetParents args.NodeIndex)
         ||
-        match (args.CheckInfo, args.ProjectCheckInfo) with
-        | Some checkFileResults, Some checkProjectResults ->
-            let projectFile = System.IO.FileInfo checkProjectResults.ProjectContext.ProjectOptions.ProjectFileName
+        match (args.CheckInfo, args.ProjectOptions.Value) with
+        | Some checkFileResults, Some projectOptions ->
+            let projectFile = System.IO.FileInfo projectOptions.ProjectFileName
             match howLikelyProjectIsLibrary projectFile.Name with
             | Likely -> false
             | Unlikely -> true

tests/FSharpLint.Core.Tests/Rules/TestAstNodeRule.fs

@@ -43,6 +43,7 @@ type TestAstNodeRuleBase (rule:Rule) =
                         GlobalConfig = resolvedGlobalConfig
                         TypeCheckResults = checkResult
                         ProjectCheckResults = None
+                        ProjectOptions = Lazy<_>(None)
                         FilePath = (Option.defaultValue String.Empty maybeFileName)
                         FileContent = input
                         Lines = (input.Split("\n"))

tests/FSharpLint.Core.Tests/Rules/TestHintMatcherBase.fs

@@ -65,6 +65,7 @@ type TestHintMatcherBase () =
                         GlobalConfig = resolvedGlobalConfig
                         TypeCheckResults = checkResult
                         ProjectCheckResults = None
+                        ProjectOptions = Lazy<_>()
                         FilePath = (Option.defaultValue String.Empty maybeFileName)
                         FileContent = input
                         Lines = (input.Split("\n"))

tests/FSharpLint.Core.Tests/Rules/TestIndentationRule.fs

@@ -38,6 +38,7 @@ type TestIndentationRuleBase (rule:Rule) =
                     GlobalConfig = resolvedGlobalConfig
                     TypeCheckResults = None
                     ProjectCheckResults = None
+                    ProjectOptions = Lazy<_>(None)
                     FilePath = resolvedFileName
                     FileContent = input
                     Lines = lines

tests/FSharpLint.Core.Tests/Rules/TestLineRule.fs

@@ -38,6 +38,7 @@ type TestLineRuleBase (rule:Rule) =
                     GlobalConfig = resolvedGlobalConfig
                     TypeCheckResults = None
                     ProjectCheckResults = None
+                    ProjectOptions = Lazy<_>(None)
                     FilePath = resolvedFileName
                     FileContent = input
                     Lines = lines