dev: schema tests output reason if "pass" test fixture fails#4455
Merged
dev: schema tests output reason if "pass" test fixture fails#4455
Conversation
duncanbeevers
approved these changes
Mar 18, 2025
Contributor
duncanbeevers
left a comment
duncanbeevers
left a comment
There was a problem hiding this comment.
This is a fine change, but I think the PR would be easier to review if you showed exactly what a failure looked like before, and what it looks like with this change applied.
This was referenced Mar 18, 2025
miqui
approved these changes
Mar 20, 2025
handrews
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quality-of-life improvement for writing "pass" test fixtures: output validation errors if a "pass" test fixture fails validation.
Tick one of the following options: