From e6077d911bf09ed813c0ab95507d5bbcb7aa0138 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Wed, 1 Apr 2026 08:34:12 -0400 Subject: [PATCH 1/3] fix: adds missing type object to action object Signed-off-by: Vincent Biret --- schemas/v1.0/schema.yaml | 1 + schemas/v1.1/schema.yaml | 1 + schemas/v1.2-dev/schema.yaml | 1 + tests/v1.0/fail/actions-item-invalid-type.yaml | 6 ++++++ tests/v1.1/fail/actions-item-invalid-type.yaml | 6 ++++++ tests/v1.2-dev/fail/action-target-invalid-type.yaml | 6 ++++++ tests/v1.2-dev/fail/actions-item-invalid-type.yaml | 6 ++++++ 7 files changed, 27 insertions(+) create mode 100644 tests/v1.0/fail/actions-item-invalid-type.yaml create mode 100644 tests/v1.1/fail/actions-item-invalid-type.yaml create mode 100644 tests/v1.2-dev/fail/action-target-invalid-type.yaml create mode 100644 tests/v1.2-dev/fail/actions-item-invalid-type.yaml diff --git a/schemas/v1.0/schema.yaml b/schemas/v1.0/schema.yaml index 000bfa9..84223b1 100644 --- a/schemas/v1.0/schema.yaml +++ b/schemas/v1.0/schema.yaml @@ -37,6 +37,7 @@ $defs: $ref: "#/$defs/specification-extensions" unevaluatedProperties: false action-object: + type: object properties: target: type: string diff --git a/schemas/v1.1/schema.yaml b/schemas/v1.1/schema.yaml index c035fb7..641ebf8 100644 --- a/schemas/v1.1/schema.yaml +++ b/schemas/v1.1/schema.yaml @@ -39,6 +39,7 @@ $defs: $ref: "#/$defs/specification-extensions" unevaluatedProperties: false action-object: + type: object properties: target: type: string diff --git a/schemas/v1.2-dev/schema.yaml b/schemas/v1.2-dev/schema.yaml index 3669a8e..4891415 100644 --- a/schemas/v1.2-dev/schema.yaml +++ b/schemas/v1.2-dev/schema.yaml @@ -39,6 +39,7 @@ $defs: $ref: "#/$defs/specification-extensions" unevaluatedProperties: false action-object: + type: object properties: target: type: string diff --git a/tests/v1.0/fail/actions-item-invalid-type.yaml b/tests/v1.0/fail/actions-item-invalid-type.yaml new file mode 100644 index 0000000..662401b --- /dev/null +++ b/tests/v1.0/fail/actions-item-invalid-type.yaml @@ -0,0 +1,6 @@ +overlay: 1.0.0 +info: + title: Action items must be objects + version: 1.0.0 +actions: + - 123 \ No newline at end of file diff --git a/tests/v1.1/fail/actions-item-invalid-type.yaml b/tests/v1.1/fail/actions-item-invalid-type.yaml new file mode 100644 index 0000000..a76326b --- /dev/null +++ b/tests/v1.1/fail/actions-item-invalid-type.yaml @@ -0,0 +1,6 @@ +overlay: 1.1.0 +info: + title: Action items must be objects + version: 1.0.0 +actions: + - 123 \ No newline at end of file diff --git a/tests/v1.2-dev/fail/action-target-invalid-type.yaml b/tests/v1.2-dev/fail/action-target-invalid-type.yaml new file mode 100644 index 0000000..2254e9f --- /dev/null +++ b/tests/v1.2-dev/fail/action-target-invalid-type.yaml @@ -0,0 +1,6 @@ +overlay: 1.2.0 +info: + title: Action target must be a string + version: 1.0.0 +actions: + - target: 100 \ No newline at end of file diff --git a/tests/v1.2-dev/fail/actions-item-invalid-type.yaml b/tests/v1.2-dev/fail/actions-item-invalid-type.yaml new file mode 100644 index 0000000..378fc74 --- /dev/null +++ b/tests/v1.2-dev/fail/actions-item-invalid-type.yaml @@ -0,0 +1,6 @@ +overlay: 1.2.0 +info: + title: Action items must be objects + version: 1.0.0 +actions: + - 123 \ No newline at end of file From 59fd22f6464351b54ab8f66f36d417e3ce5e1202 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Wed, 1 Apr 2026 08:35:34 -0400 Subject: [PATCH 2/3] tests: adds missing test for invalid version pattern in v1.2 --- tests/v1.2-dev/fail/overlay-invalid-pattern.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 tests/v1.2-dev/fail/overlay-invalid-pattern.yaml diff --git a/tests/v1.2-dev/fail/overlay-invalid-pattern.yaml b/tests/v1.2-dev/fail/overlay-invalid-pattern.yaml new file mode 100644 index 0000000..ba43e98 --- /dev/null +++ b/tests/v1.2-dev/fail/overlay-invalid-pattern.yaml @@ -0,0 +1,6 @@ +overlay: '1.2' +info: + title: Overlay version must match 1.1.x + version: 1.0.0 +actions: + - target: '$' \ No newline at end of file From 91b43093a6c570442cc9b4d347781550f11388d9 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Wed, 1 Apr 2026 08:42:17 -0400 Subject: [PATCH 3/3] chore: updates the description --- tests/v1.2-dev/fail/overlay-invalid-pattern.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/v1.2-dev/fail/overlay-invalid-pattern.yaml b/tests/v1.2-dev/fail/overlay-invalid-pattern.yaml index ba43e98..95d584a 100644 --- a/tests/v1.2-dev/fail/overlay-invalid-pattern.yaml +++ b/tests/v1.2-dev/fail/overlay-invalid-pattern.yaml @@ -1,6 +1,6 @@ overlay: '1.2' info: - title: Overlay version must match 1.1.x + title: Overlay version must match 1.2.x version: 1.0.0 actions: - target: '$' \ No newline at end of file