-
Notifications
You must be signed in to change notification settings - Fork 15
docs: adds a json schema namespace #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||||||||||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||||||||||||
| owner: OAI | ||||||||||||||||||||||||||||||||||
| issue: | ||||||||||||||||||||||||||||||||||
| description: JSON Schema keywords exposed as OpenAPI Specification Extensions for versions that do not directly support them. | ||||||||||||||||||||||||||||||||||
| layout: default | ||||||||||||||||||||||||||||||||||
| registry: ../extension/index.html | ||||||||||||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| {% capture summary %} | ||||||||||||||||||||||||||||||||||
| The `x-{{page.slug}}-` prefix is reserved for OpenAPI Specification Extensions that mirror JSON Schema keywords when targeting OpenAPI versions or JSON Schema dialects where those keywords are not directly available. | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| Extensions in this namespace are registered in the [OpenAPI Extension Registry](../extension/), like the `x-oai-` and `x-oas-` namespaces. | ||||||||||||||||||||||||||||||||||
| {% endcapture %} | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+10
to
+13
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we make a note that, strictly speaking,
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @handrews are you suggesting that we also reserve the
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mikekistler no, I mean tht some JSON Schema implementations will just allow, say, Although come to think of it, this wouldn't be a problem in 3.1+ unless you had already set I see some extension entries say something like "used when targeting OpenAPI versions prior to 3.2", so I think this whole namespace should have "used when targeting OpenAPI versions prior to 3.1" on it, and that would be sufficient. Ignore all the rest of what I said.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
does that work?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I'd like to propose this way of expressing this:
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @baywet Are there tools that require or benefit from the
All JSON Schema keywords/properties are supported in OAS 3.1. Anything you can possibly do with JSON Schema is supported in OAS 3.1 (although tool support matters more than theoretical support- again, point me to tools that support one thing and not the other and I'll be very interested in that).
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @baywet @mikekistler to try to make this a little more focused, IIRC @lornajane noted that she'd seen OAS 3.1 documents using So the question is: If such a user wanted to selective "import" 2020-12 keywords from the future, how did they do it, and what tools supported it? That is the question we need to answer. I am against fracturing the JSON Schema ecosystem with
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be clear, I started all of that for 3.0, not 3.1+ I'm also struggling to see why would anybody downgrade their schema version in 3.1 and need the extensions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yes. No one is disputing this for 3.0. But the language around "JSON Schema dialects" can only ever apply to 3.1+, which is why I'm pushing on it.
Exactly! This is my entire point! So why should we confuse people with language about "JSON Schema dialects" in either this namespace registration or the individual extensions. Just say it's for 3.0 and leave it at that!
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @handrews would this edit work for you?#110 (comment) @mkistler are you ok with letting go of the dialect scenario? |
||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| {% include namespace-entry.md summary=summary %} | ||||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.