ci: multiple ruby configuration fixes#115
Conversation
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Ruby/Jekyll toolchain for the site to improve local development and updates CI/CD to deploy the site via a dedicated GitHub Actions Pages workflow.
Changes:
- Replace the
github-pagesgem stack with directjekyll ~> 4.4dependencies and refresh the lockfile (Bundler 2.6.x). - Add a GitHub Actions workflow to build and deploy the Jekyll site to GitHub Pages.
- Improve local dev ergonomics via updated Docker instructions, a VS Code task, and ignoring the local Bundler cache (
.bundle/).
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Gemfile.lock |
Updates dependency resolution to Jekyll 4.4.x and newer supporting gems; updates Bundler version. |
Gemfile |
Switches from github-pages to direct jekyll + plugin/theme gems for local dev compatibility. |
CONTRIBUTING.md |
Updates Docker-based dev instructions and documents the new VS Code task. |
.vscode/tasks.json |
Adds a VS Code task to run Jekyll via Docker with a local gem cache path. |
.gitignore |
Ignores .bundle/ created by the Docker/local bundler cache path. |
.github/workflows/deploy-pages.yml |
Adds a Pages build+deploy workflow using Ruby setup, Jekyll build, and Pages artifact/deploy actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Running locally works on macOS Haven't checked the new publishing workflow, not my area of expertise. |
|
Thanks for confirming all those platforms @ralfhandl |
|
Did you test the new publishing workflow in a fork of this repo? |
|
@ralfhandl I can't, we need to change a setting on the repo as far as I understand, and I don't have those permissions |
|
If you fork the repo, you have the permissions in your fork to deploy to the default GH-pages site. And this is a good test of what you have to change in the GH-pages settings. |
|
I've created a fork that uses Not my area of expertise, so I won't dig into why it looks so weird. |
|
@ralfhandl this is cause by the combination of the facts:
I've pushed a fix, could you merge that into your fork please? (not setting up my own fork because I have a blog at https://baywet.github.io and I'm afraid it'll mess it up) |
ralfhandl
left a comment
There was a problem hiding this comment.
Looks good now on https://ralfhandl.github.io/spec.openapis.org/
|
@baywet Do you want to resolve the Copilot review comments? |
this PR drops a bunch of outdated gems that made it difficult / impossible to run the site locally. It also switches from automatic publishing to workflow based (we'll need to flip the switch in the settings) and adds a vscode task to run the container